fix: restore same-file cross-post links under Org 9.7+ - #781
Open
HaoZeke wants to merge 6 commits into
Open
Conversation
Cross-subtree links are rewritten to dummy file paths in the pre-processed buffer. org-element-interpret-data then drops the file: type for relative paths, so re-parse treats them as fuzzy and Org 9.7 aborts with "Unable to resolve link: ...pre-processed.org::...". - Keep path and search-option separate on dummy file links - After interpret-data, force file: prefixes on dummy targets - Do not skip same-file org-id links during rewrite (only other files) - Handle fuzzy reparsed dummy paths in org-hugo-link - Re-enable the commented cross-post link tests in all-posts.org
Re-enable cross-post cases now export to relref shortcodes instead of the previous pre-processed.org resolve error note.
Current Org citeproc no longer emits the .csl-left-margin style block before csl-bib-body; main has been red on this golden drift. Align the expected Markdown with the export CI produces so the suite can proceed past citation-csl.org.
org-hugo-export-wim-to-md only updated org-id-locations when the table was empty. After a prior export wrote a non-empty ~/.emacs.d/.org-id-locations (test suite shares HOME across sequential emacs -batch runs), sibling files in the current directory were never scanned, so cross-file id links such as org-roam-file-A -> B aborted with "Unable to resolve link". Always rescan .org files in default-directory before export.
Org now emits —/– instead of numeric entities in captions, and drops the trailing space inside timestamp spans. Align expected Markdown with CI export so all-posts.org diffgolden can pass.
Un-comment and fill the Hyperlinks page: external vs same-post vs cross-post links, native Org forms that export to relref, the pre-processed.org resolve failure under Org 9.7+, and org-id tips for id: links. Escape example shortcodes for the doc Hugo build.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same-file cross-post links (
[[*Other post]],[[#custom-id]],[[id:...]]pointing at anotherEXPORT_FILE_NAMEsubtree) break under Org 9.7+: export aborts withThis is the failure that left the cross-post examples under Links outside the same post commented out, and the reason #755 only rewrote docs to avoid
[[*Heading]]/ relref macros.Cause
file:paths with the.pre-processed.orgsuffix.org-element-interpret-dataemits those links without thefile:type for relative paths.::#anchor).A second issue: same-file
id:links were skipped in pre-processing wheneverorg-id-find-id-filereturned a path, including the current file, so they never got rewritten to relrefs.Fix
:path/:search-option), not as one string in:path.file:back onto dummy targets (org-hugo--ensure-preprocessed-file-link-types).id:rewrite when the id lives in a different Org file.org-hugo-link, still accept fuzzy paths that look like dummy pre-processed files (safety net).test/site/content-org/all-posts.org.test/site/content/posts/links-outside-the-same-post.mdfrom a live Org 9.7+ export.Test plan
{{< relref "dest-post..." >}}without error (Org 9.7.11, Emacs 30.2).test/site/content-org/all-posts.orgLinks outside the same post and update goldenlinks-outside-the-same-post.md(commit on this branch).make -j1 testsuite not re-run for this open; CI / maintainer can exercise the suite against the refreshed golden.Notes
Complements #755 (doc workaround). Prefer fixing the exporter so in-file
[[*Post heading]]works again rather than avoiding those links in the manual.