Skip to content

fix: make FlowMigration project clients pass phpstan against manage-api ^10 #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jirkasemmler wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: make FlowMigration project clients pass phpstan against manage-api ^10 #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/Keboola/Console/Command/FlowMigration/ProjectClientsFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public function __construct(ManageClient $manageClient, string $connectionUrl, s
*/
public function getProject(string $projectId): array
{
return $this->manageClient->getProject($projectId);
return $this->manageClient->getProject((int) $projectId);
}

public function createProjectClients(string $projectId): ProjectClients
Expand All @@ -47,7 +47,7 @@ public function createProjectClients(string $projectId): ProjectClients
// (with a runWithTokenId copied from the source trigger, i.e. another token) and
// notification subscriptions, and a migration failing halfway through is worse than a
// short-lived privileged token. Restricting this only risks the component missing something.
$tokenInfo = $this->manageClient->createProjectStorageToken($projectId, [
$tokenInfo = $this->manageClient->createProjectStorageToken((int) $projectId, [
'description' => self::TOKEN_DESCRIPTION,
'expiresIn' => self::TOKEN_EXPIRES_IN_SECONDS,
'canManageBuckets' => true,
Expand All @@ -56,14 +56,17 @@ public function createProjectClients(string $projectId): ProjectClients
'canPurgeTrash' => true,
]);

$token = $tokenInfo['token'];
assert(is_string($token));

$storageClient = new StorageClient([
'url' => $this->connectionUrl,
'token' => $tokenInfo['token'],
'token' => $token,
]);

return new ProjectClients(
new Components($storageClient),
new JobQueueClient($this->queueApiUrl, $tokenInfo['token'])
new JobQueueClient($this->queueApiUrl, $token)
);
}
}