Skip to content

[kensho_kenverters] Add table cell hierarchy tree construction. - #46

Merged
libinliang866 merged 4 commits into
mainfrom
libin/add_table_cell_hierarchy_tree_constructing
Jul 10, 2026
Merged

libinliang866 merged 4 commits into
mainfrom
libin/add_table_cell_hierarchy_tree_constructing

Conversation

@libinliang866

Copy link
Copy Markdown
Contributor

Added

  • Add the codes to construct the table cell hierarchy tree.

@libinliang866
libinliang866 marked this pull request as ready for review July 9, 2026 19:17

@maxim-sokolov-kensho maxim-sokolov-kensho left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Libin! The comments helped. I only have a small nit about the changelog

Comment thread kensho_kenverters/CHANGELOG.md Outdated

### Added

* Add codes to construct table cell hierarchy tree.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think we usually use code (instead of codes) when we talk about writing code (as opposed to ciphers)

@maxim-sokolov-kensho maxim-sokolov-kensho left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to be OOO --- approving to unblock

@libinliang866
libinliang866 merged commit 74c8ca3 into main Jul 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants