ci: use the SDK release app for version bumps - #223
Merged
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Larry-Osakwe
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The version bump job minted its token from
GH_REPO_ACCESS_*— the enterprisekeycard-gha-repository-accessapp, which is installed across keycardlabs as well. Any workflow holding that private key can mint an installation token for every private keycardlabs repo, so a compromised bump job (or a compromised action in it) reached far outside this repo.SDK_RELEASE_*is a keycardai-owned app installed only ongo-sdk,python-sdkandtypescript-sdk, with contents + pull-requests write and noWorkflows: write, and its credentials live as repo secrets on those three repos rather than an org secret. Behavior is unchanged: it's still an app token, notGITHUB_TOKEN, so the tag push still triggers the publish workflow (GITHUB_TOKENpushes do not trigger workflows, which would leave the version bumped and nothing published).Prerequisites
SDK_RELEASE_APP_IDandSDK_RELEASE_PRIVATE_KEYmust exist as repo secrets here, and the app must be on therequireReviewbypass list (rulesets:requireReviewBypassActorsinkeycardlabs/infra,stacks/github/Pulumi.keycardai.yaml) so it can merge the bump PR / push tomain.Residual, for the record: any of the three SDK repos' CI can mint a token for the other two — inherent to app installation scoping, and now confined to keycardai.
Part of the GitHub Actions cross-org audit (keycardlabs <-> keycardai): finding F1.
Link to Devin session: https://app.devin.ai/sessions/6197211c97f643b09c1e0ace7b92d29f
Requested by: @kiambogo