Skip to content

[#1212] Directly render auth error page instead of redirect - #1213

Merged
marlonbaeten merged 4 commits into
mainfrom
direct-auth-error-rendering
Sep 16, 2026
Merged

marlonbaeten merged 4 commits into
mainfrom
direct-auth-error-rendering

Conversation

@marlonbaeten

@marlonbaeten marlonbaeten commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Closes #1212

DOD checklist

For PR maintainer

Perform these checks before marking the PR as ready:

  • I have linked the PR to at least one issue.
  • I assigned the PR to myself.
  • I have added a description how to test this PR (see "Review Instructions").
  • I have added documentation where necessary.

For reviewer

  • I have read all code changes.
  • I have audited the code quality.
  • I have tested the changes either or both:
    • locally
    • on the test environment (preferred)
  • I have validated that the PR is functionally correct (use-cases, figma designs, etc.)

Review instructions

Test the authentication cancel / error flow on our preview environment.

@github-actions

Copy link
Copy Markdown

Sigrid maintainability feedback

💭️ You did not change any files that are analyzed by Sigrid.


View this system in Sigrid

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

PDF diff summary

Template Input Status
model-h1 model-h1-example-1.pdf 🔵 identical
model-h1 model-h1-example-2.pdf 🔵 identical
model-h1 model-h1-example-3.pdf 🔵 identical
model-h3-1 model-h3-1-example-1.pdf 🔵 identical
model-h3-1 model-h3-1-example-2.pdf 🔵 identical
model-h3-1 model-h3-1-example-3.pdf 🔵 identical
model-h3-2 model-h3-2-example-1.pdf 🔵 identical
model-h3-2 model-h3-2-example-2.pdf 🔵 identical
model-h3-2 model-h3-2-example-3.pdf 🔵 identical
model-h4 model-h4-example-1.pdf 🔵 identical
model-h4 model-h4-example-2.pdf 🔵 identical
model-h4 model-h4-example-3.pdf 🔵 identical
model-h9 model-h9-example-1.pdf 🔵 identical
model-h9 model-h9-example-2.pdf 🔵 identical
model-h9 model-h9-example-3.pdf 🔵 identical
model-i1 model-i1-example-1.pdf 🟠 changed
model-i1 model-i1-example-2.pdf 🟠 changed
model-i4 model-i4-example-1.pdf 🔵 identical
model-i4 model-i4-example-2.pdf 🔵 identical
verzuimbrief verzuimbrief-example-1.pdf 🔴 deleted
verzuimbrief verzuimbrief-example-2.pdf 🔴 deleted

Download diff artifacts

Drevanoorschot
Drevanoorschot previously approved these changes Sep 15, 2026
Comment thread auth-service/src/handlers/flow.rs
@sonarqubecloud

Copy link
Copy Markdown

@marlonbaeten
marlonbaeten merged commit c273bbd into main Sep 16, 2026
20 checks passed
@marlonbaeten
marlonbaeten deleted the direct-auth-error-rendering branch September 16, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Directly render authentication errors instead of redirecting to a error page

2 participants