[#1217] Use the term "domain" instead of "region" to describe an election domain - #1218
Merged
Merged
Conversation
Sigrid maintainability feedbackShow detailsSigrid compared your code against the baseline of 2026-09-16. 👍 What went well?
👎 What could be better?
📚 Remaining technical debt
View this system in Sigrid to explore your technical debt ⭐️ Sigrid ratings
💬 Did you find this feedback helpful?We would like to know your thoughts to make Sigrid better. |
PDF diff summary
|
marlonbaeten
approved these changes
Sep 16, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #1217
Inspired by Ruben's presentation today
DOD checklist
For PR maintainer
Perform these checks before marking the PR as ready:
For reviewer
Review instructions
The EML's for election with multiple domains should now list a
kr:ElectionDomain. The rest of the application should not behave any differently than normal.