Fix build pipeline - #9
Merged
Merged
Conversation
Otherwise hatch reports formatting errors in pyapp code
oliver3
approved these changes
Jan 30, 2026
oliver3
left a comment
oliver3
left a comment
Contributor
There was a problem hiding this comment.
I see that the python version of the windows build is now also brought into line with the linux build and the test workflow 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the linting and testing step to before the clone of pyapp.
For some reason on the Hatch otherwise also reports formatting errors in pyapp code when building on
ubuntu-latest.By making sure that the pyapp folders don't exist yet when the linting and testing runs we are sure that the results only report on the
eml2csvcode.See https://github.com/kiesraad/eml2csv/actions/runs/21513056423