feat(kommodity-cluster): render TALOS_AUTO_BOOTSTRAP_SCAN_CIDR override - #467
Open
Andreas Wachs (andreaswachs) wants to merge 2 commits into
Open
Andreas Wachs (andreaswachs) wants to merge 2 commits into
Andreas Wachs (andreaswachs) wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the kommodity-cluster Helm chart to support overriding the autobootstrap peer-discovery scan range via TALOS_AUTO_BOOTSTRAP_SCAN_CIDR, which is needed on platforms like Azure where /32 node addresses can break discovery. It also bumps the chart version to publish the change.
Changes:
- Add an optional
talos.autoBootstrap.scanCIDRvalue (documented invalues.yaml) and conditionally renderTALOS_AUTO_BOOTSTRAP_SCAN_CIDRwhen set. - Bump chart version from
0.28.3to0.28.4.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/kommodity-cluster/values.yaml | Documents the new optional talos.autoBootstrap.scanCIDR override value. |
| charts/kommodity-cluster/templates/talos/autobootstrap.yaml | Conditionally renders TALOS_AUTO_BOOTSTRAP_SCAN_CIDR env var when scanCIDR is provided. |
| charts/kommodity-cluster/Chart.yaml | Chart version bump to release the change. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+21
to
+23
| {{- if $autoBootstrap.scanCIDR }} | ||
| - TALOS_AUTO_BOOTSTRAP_SCAN_CIDR={{ $autoBootstrap.scanCIDR }} | ||
| {{- end }} |
Go test coverage: 24.2% for commit 9d6d791
|
Copilot started reviewing on behalf of
Andreas Wachs (andreaswachs)
August 20, 2026 18:07
View session
Add conditional scanCIDR env var to the autobootstrap ExtensionServiceConfig so operators can override the auto-detected scan CIDR on multi-interface hosts (e.g. Azure Accelerated Networking). Backward-compatible: no env var rendered when scanCIDR is unset. Signed-off-by: Andreas Wachs <awa@corti.ai>
Signed-off-by: Andreas Wachs <awa@corti.ai>
Andreas Wachs (andreaswachs)
force-pushed
the
fix/autobootstrap-scan-cidr-cherry
branch
from
August 20, 2026 19:57
38b1518 to
78cb4da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks the
TALOS_AUTO_BOOTSTRAP_SCAN_CIDRrendering andquorumNodesdefault fromfix/autobootstrap-scan-cidr-chartonto currentmain. Required to test the autobootstrap fix on Azure where /32 node addresses break peer discovery.Changes
templates/talos/autobootstrap.yaml: conditionalTALOS_AUTO_BOOTSTRAP_SCAN_CIDRenv var +quorumNodesdefaults tofloor(replicas/2)+1when nullvalues.yaml: addsscanCIDRfield,quorumNodesdefaults to nullChart.yaml: version bump 0.28.3 -> 0.28.4Why
Azure assigns /32 node addresses. The autobootstrap extension's
GetNetworkInfo()derives the scan CIDR from the interface prefix, producing 0 IPs on /32. TheTALOS_AUTO_BOOTSTRAP_SCAN_CIDRenv var lets operators override the scan range. ThequorumNodesdefault prevents split-brain when the chart knows the control plane count.Testing
Chart published to
ghcr.io/kommodity-io/charts/kommodity-cluster:0.28.4. Successfully validated by recreating dev-ams99 withquorumNodes=2andscanCIDR=10.0.0.0/24:Depends on kommodity-io/kommodity-autobootstrap-extension#33 for the extension fixes (split-brain prevention, mTLS probe auth, scanCIDR override support).