Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/main/java/kyu7/SquareDigit.java
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
package kyu7;


import static common.SafeParse.parseInt;


public class SquareDigit {

private static final String MAX_INT = Integer.toString(Integer.MAX_VALUE);

//7 https://www.codewars.com/kata/546e2562b03326a88e000020/train/java

public static int squareDigits(int n) {
Expand All @@ -16,7 +15,12 @@
n /= 10;
stringBuilder.insert(0, i * i);
}
return parseInt(stringBuilder.toString());
String result = stringBuilder.toString();
if (result.length() > MAX_INT.length()
|| result.length() == MAX_INT.length() && result.compareTo(MAX_INT) > 0) {
return Integer.MAX_VALUE;
}
return Integer.parseInt(result);

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note

Potential uncaught 'java.lang.NumberFormatException'.
Comment thread
krotname marked this conversation as resolved.
}

}
10 changes: 10 additions & 0 deletions src/test/java/kyu7/SquareDigitTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,16 @@
import static kyu7.SquareDigit.*;
@Tag("smoke")
public class SquareDigitTest {
@Test
void squaresDigitsWhenResultFitsInAnInteger() {
assertEquals(811181, squareDigits(9119));
}

@Test
void capsResultsThatExceedIntegerRange() {
assertEquals(Integer.MAX_VALUE, squareDigits(99999));
}

@Test
void smokeTestsShouldExecuteApi() {
quality.SmokeMethodTestHarness.verify(kyu7.SquareDigit.class);
Expand Down