Handle overflow when reversing integers - #111
Closed
krotname wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Закрываю как superseded by #116: изменения перенесены в одну проверенную ветку, все review findings учтены; локальный mvn verify прошёл полностью. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ReverseInt.reverse(int)reversed the decimal string and usedInteger.parseInt, which throwsNumberFormatExceptionwhen the reversed value exceeds 32-bit signedintbounds.Description
Integer.parseIntwith parsing the reversed magnitude into alongusingLong.parseLongafterMath.abs((long) x), then restore the sign and clamp out-of-range results.0when the reversed value is outsideInteger.MIN_VALUE..Integer.MAX_VALUEwhile preserving previous behavior for in-range results.src/main/java/other/ReverseInt.javato implement thelong-based reversal and bound check.src/test/java/other/ReverseIntTest.javawith regression cases for a positive overflow (1534236469) andInteger.MIN_VALUEto ensure overflow returns0.Testing
mvn -B -Dtest=other.ReverseIntTest test, and the test suite for that class passed (8 tests, 0 failures).mvn -B verify, and the project completed successfully (599 tests run, 0 failures) with Checkstyle, PMD, and SpotBugs analysis passing.Codex Task