Validate resistor input before color encoding - #114
Closed
krotname wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fe03ea6e25
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
Author
|
Закрываю как superseded by #116: изменения перенесены в одну проверенную ветку, все review findings учтены; локальный mvn verify прошёл полностью. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ResistorColorCodes2.encodeResistorColorsaccepted any string ending with" ohms"but did not validate the numeric token, allowing malformed, negative, or non-finite values to causeNumberFormatExceptionor invalid enum indexes and crash the encoder.Description
encodeResistorColorswith atry/catchthat returns an empty string for invalid inputs instead of propagating exceptions.encodeResistorOhmsusingDouble.isFinite(tempValue)and a range check (tempValue < 10 || tempValue > 990_000_000) and throwIllegalArgumentExceptionfor values outside the supported 10 ohm to 990M ohm range.ResistorColorCodes2Testto add regression assertions thatencodeResistorColorsreturns""for malformed and out-of-range inputs such as"abc ohms","-1 ohms", and"1e309 ohms".src/main/java/kyu5/ResistorColorCodes2.java,src/test/java/kyu5/ResistorColorCodes2Test.java.Testing
mvn -q -Dtest=kyu5.ResistorColorCodes2Test testand the test class passed.mvn -q testand the build/tests completed successfully.Codex Task