Validate FastSort stdin bounds - #85
Closed
krotname wants to merge 1 commit into
Closed
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Owner
Author
krotname
deleted the
codex/fix-fastsort-stdin-unbounded-allocation-issue
branch
August 1, 2026 02:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Motivation
OutOfMemoryErrororNegativeArraySizeExceptionin the FastSort CLI.Description
MAX_PARTICIPANTSandMAX_LOGIN_LENGTHconstants and apply them in the CLI run path to limit allocations and token sizes.nextInt()withnextInt(String fieldName, int minValue, int maxValue)that enforces digit-only input, overflow checks, and min/max bounds.next()withnext(int maxLength)and introducenextNonWhitespace()so tokens are read with a maximum length check and fail early if exceeded.run()so theParticipant[]allocation and each login/solved/penalty read are validated while preserving existing sorting behavior for valid inputs.Testing
mvn testwhich completed successfully (BUILD SUCCESS, 546 tests run) and all unit tests passed.javac -g src/main/java/algorithms/sprint3/FastSort.javawhich succeeded.2147483648,1000000000and an excessively long login token produced validationIOExceptionand non-zero exit as expected.Codex Task