Validate SleightOfHand input - #88
Closed
krotname wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d1e321ac30
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Owner
Author
|
Закрываю как superseded by #116: изменения перенесены в одну проверенную ветку, все review findings учтены; локальный mvn verify прошёл полностью. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Motivation
Description
next(int maxLength)and switch board reads toin.next(4)so oversized row tokens are rejected before unbounded buffer growth can exhaust memory.IOExceptionfor any non-.and non-digit character before indexingcount[ch - '0'].maininvocation in atry/catchto reportIOExceptionandIllegalArgumentExceptionmessages instead of letting uncaught exceptions crash the process.solve(int, int[][])and throwIllegalArgumentExceptionfor values outside0..9before indexing the digitcountarray.Testing
mvn test -qwas attempted but failed due to Maven Central returning503 Service Unavailablewhile resolving the JUnit BOM.javacand ran a valid sample input which produced the expected output2(succeeded).!and observed a handledIOExceptionwith messageInvalid grid cell: !(succeeded).-Xmx16mand observedIOException: Token length exceeds 4, preventing heap exhaustion (succeeded).solve(1, new int[][]{{10,0,0,0}})and observedIllegalArgumentException: Grid values must be between 0 and 9(succeeded).Codex Task