Skip to content

Fail smoke tests when any reflected invocation fails #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krotname wants to merge 1 commit into from
Closed

Fail smoke tests when any reflected invocation fails #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test/java/quality/SmokeMethodTestHarness.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public static void verify(Class<?> clazz) {
}

String summary = String.format("%s attempted=%d failed=%d", clazz.getSimpleName(), attempted, failed);
Assertions.assertTrue(failed < attempted, () -> "Every executable smoke path failed: " + summary);
Assertions.assertEquals(0, failed, () -> "Executable smoke path failed: " + summary);
}

private static Object resolveTargetInstance(Method method, Class<?> clazz) throws Exception {
Expand Down
5 changes: 2 additions & 3 deletions src/test/java/quality/SmokeMethodTestHarnessTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package quality;

import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertThrows;

import org.junit.jupiter.api.Test;
Expand All @@ -13,8 +12,8 @@ void rejectsClassesWhoseEveryExecutablePathFails() {
}

@Test
void acceptsAClassWhenAtLeastOneExecutablePathSucceeds() {
assertDoesNotThrow(() -> SmokeMethodTestHarness.verify(PartiallyWorks.class));
void rejectsAClassWhenAnyExecutablePathFails() {
assertThrows(AssertionError.class, () -> SmokeMethodTestHarness.verify(PartiallyWorks.class));
}

private static final class AlwaysFails {
Expand Down