feat(crypto): add aes gcm algorithm - #18
Merged
Merged
Conversation
drichard-k
approved these changes
Aug 10, 2026
|
🎉 This PR is included in version 2.1.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR deprecates the legacy
aes-256-cbccipher and introduces support for the more secureaes-256-gcmencryption algorithm.To preserve backward compatibility,
aes-256-cbcremains the default behavior. The newaes-256-gcmcipher is opt-in via a configuration setting. Migration documentation and a script snippet are also provided directly in the README.How should this be manually tested?
.enc.jsonfile generated with theaes-256-cbccipherVaultinstanceREADME.mdto re-encrypt the secrets.enc.jsonfile. The encrypted strings should now contain 3 segments separated by dots:<encrypted-data>.<iv>.<auth-tag>.Other changes
mock-fswith native temporary files (fs.writeFileSync) intest/Vault.test.ts, asmock-fsbreaks the test suite on modern versions of Node.