Disable leftover Reports and Clipboard session verbs - #291
Merged
Merged
Conversation
Keep the command palette on the same enablement rules as the menus so unused compare verbs stay off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reports and Clipboard Compare still left a few Session/View verbs clickable even though those sessions never run them. The command palette also ignored the same enablement rules as the menus.
This change:
Run Script and Save Report stay available on Reports. Text Merge four-pane and live Registry hive are still out of scope.
Type of change
Validation
corepack pnpm format:checkcorepack pnpm lintcorepack pnpm stylelintcorepack pnpm typecheckcorepack pnpm exec vitest run src/app/menuTables.test.ts src/app/shellChrome.test.ts src/layouts/AppLayout.test.tsLocal Rust clippy needs GTK on this Linux host; Windows Quality CI covers that.
Checklist