Wire Media and Version Session Rules and Settings - #295
Merged
Merged
Conversation
Session Rules and Session Settings stayed enabled on Media Compare and Version Compare but did nothing. Both sessions already have an importance rules panel on the toolbar; the menu verbs now toggle that same panel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Session Rules and Session Settings stayed enabled on Media Compare and Version Compare but did nothing. Both sessions already expose an importance rules panel from the toolbar.
This change toggles that same panel from the Session menu verbs, so the enabled items actually run.
No Sync/Merge or chrome work in this PR. Remaining unused menu verbs on those sessions stay disabled. Text Merge four-pane layout and live Registry hive are still out of scope.
Type of change
Validation
corepack pnpm format:checkcorepack pnpm lintcorepack pnpm stylelintcorepack pnpm typecheckcorepack pnpm test:unitLocal Rust clippy needs GTK development packages that this host does not have; Windows Quality CI covers that.
Checklist