Enable Hex Compare Edit Copy for selected bytes - #296
Merged
Merged
Conversation
Edit > Copy now uses the existing selected-byte clipboard handler. Cut and paste stay disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hex Compare already copies the selected byte from the session toolbar. Edit > Copy stayed disabled with Cut and Paste.
This enables Edit > Copy on Hex Compare and routes it through that existing handler. Cut and Paste stay disabled.
Type of change
Validation
corepack pnpm format:checkcorepack pnpm lintcorepack pnpm stylelintcorepack pnpm typecheckcorepack pnpm exec vitest run src/app/menuTables.test.ts src/layouts/AppLayout.test.ts src/views/HexCompareView.test.tsLocal Rust clippy could not run here (missing GTK). Quality on this PR is the Windows CI job.
Checklist