feat: add SSH config runtime foundation (#295) - #302
Merged
Conversation
inureyes
force-pushed
the
feature/issue-295-ssh-config-foundation
branch
from
August 27, 2026 10:51
be14191 to
a7051f0
Compare
Introduce a canonical accepted-keyword registry that distinguishes concrete runtime consumers, delegated first-wave work, and recognized-but-unimplemented options so unsupported behavior is never silently claimed. Preserve structured Include provenance and OpenSSH first-obtained semantics across global, Host, Match, nested Include, SetEnv, and generic command-line overlays. Wire validated cipher, MAC, KEX, host-key, and public-key policies into russh, implement bounded carrier retries and verified TCP keepalive, and preserve typed packet-integrity failures without retrying authentication or protocol failures. Add the cross-phase OpenSSH -c and -m compatibility needed by the #295 named regressions; dedicated flags precede generic -o values, and unsupported or empty policies fail closed. Validated with focused ssh_config, transport, algorithm, error, CLI, jump-chain, diagnostic, harness self-tests, scoped check/clippy, and the integrity, try-ciphers, kextype, and keytype regressions. Refs #295
inureyes
force-pushed
the
feature/issue-295-ssh-config-foundation
branch
from
August 27, 2026 11:13
a7051f0 to
b546991
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
-Ewithout trusting user-authored# Source:comments.-o Key=Valuevalues, scalar first-obtained fields, additive fields, and SetEnv key-level first writes.Compatibility notes
-cand-mportion of feat(cli): implement -c, -m, -s, -n and -W #285 ahead of its normal phase because the feat(ssh_config): add directive registry and transport runtime foundation #295 namedtry-ciphersandintegrityregressions invoke those OpenSSH flags directly; dedicated flags precede generic-o Ciphersand-o MACs, and feat(cli): implement -c, -m, -s, -n and -W #285 must not implement them again.Validation
cargo test --lib ssh::ssh_config(230 passed)cargo test --lib ssh::tokio_client::connection_tests(26 passed)make openssh-regress-selftest(13 passed)cargo fmt --all -- --checkcargo check --lib --bins --testscargo clippy --lib --bins --tests -- -D warningsintegrity,try-ciphers,kextype, andkeytype(4/4 passed)Closes #295
Part of #281 and #275