fix: resolve RealIP for bare RemoteAddr without port#3054
Open
sonnemusk wants to merge 1 commit into
Open
Conversation
RealIP and LegacyIPExtractor discarded the address when net.SplitHostPort failed (e.g. bare IPv4/IPv6 without :port). Reuse extractIP so behavior matches ExtractIPDirect.
Contributor
|
In which environment |
Author
|
Good question — under a normal Where a bare IP shows up in practice:
So this is less “production TCP omits the port” and more “make the documented fallback robust and consistent with |
sonnemusk
force-pushed
the
fix/realip-bare-remote-addr
branch
from
July 22, 2026 07:56
e98a6ab to
c0d7fc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context.RealIP()(and theLegacyIPExtractorfallback) usednet.SplitHostPortand ignored the error, so a bare IPRemoteAddr(no:port) returned an empty string.Change
extractIP, the same helper used byExtractIPDirect.RemoteAddrvalues.Test plan
go test . -run TestContext_RealIP