Repository navigation
Conversation
|
Hardhat Unit Tests Coverage SummaryDetailsDiff against masterResults for commit: f5849be Minimum allowed coverage is ♻️ This comment has been updated with latest results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1996 currently fails on an unmodified pre-activation mainnet fork: the new top-up suite and the positive CL rebase accounting test require CSM 0x02 to be registered.
Add INTEGRATION_WITH_CSM0x02=off for explicit pre-activation fork runs. The guard skips only when the module is absent on a non-scratch deployment. Registered modules always run, even with the opt-out; scratch deployments always require registration. Provisioning, queue, gate, deposit and accounting failures propagate normally. The existing accounting test continues with all prior assertions when only the additional CSM fixture is omitted.
Mainnet CI remains strict: no opt-out is added to workflows. Merge #1996 only after confirmed DG execution, module registration and a successful integration run against the activated state. The expected 2026-10-23 date in scripts#691 is not execution evidence. Alternatively, scripts#691 already provides post-proposal fork preparation in its Core tests workflow (prepare environment, refresh vaults report, run core tests); core's UPGRADE=true path is not a replacement for that CSM proposal.
Validation:
For an explicitly pre-activation fork: INTEGRATION_WITH_CSM0x02=off NETWORK=mainnet RUN_NETWORK=local yarn test:integration. Omit the flag for scratch, prepared post-proposal forks and post-activation mainnet CI.