Skip to content

Fix linuxdeploy log directory rename - #177

Merged
TheAssassin merged 1 commit into
linuxdeploy:masterfrom
dantti:dantti/fix_linuxdeploy_log_include
Aug 18, 2025
Merged

Fix linuxdeploy log directory rename#177
TheAssassin merged 1 commit into
linuxdeploy:masterfrom
dantti:dantti/fix_linuxdeploy_log_include

Conversation

@dantti

@dantti dantti commented Jun 18, 2024

Copy link
Copy Markdown
Contributor

Since I needed linuxdeploy-plugin-qt that had the --exclude-libraries working I make the github workflows run on my fork and and have this issue when using a newer (+my patch) linuxdeploy submodule.

@bjorn

bjorn commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

For context, this adjustment is necessary in response to linuxdeploy/linuxdeploy@2b73a21.

It's a bit unfortunate the move happened as part of "Improve logging of failed subprocesses", since it makes it very hard to see what the actual improvement was (I couldn't spot it).

@TheAssassin

Copy link
Copy Markdown
Member

It's a bit unfortunate the move happened as part of "Improve logging of failed subprocesses", since it makes it very hard to see what the actual improvement was (I couldn't spot it).

You're absolutely right about this. This was rushed a bit. It shouldn't be a big deal to use a tool like Meld and diff the old and new code, though.

At any rate, @dantti please rebase this branch, then we can merge it.

@dantti
dantti force-pushed the dantti/fix_linuxdeploy_log_include branch 2 times, most recently from 70e3e97 to 90703c8 Compare August 4, 2024 02:04
@dantti
dantti force-pushed the dantti/fix_linuxdeploy_log_include branch from 90703c8 to 3d9d609 Compare August 11, 2024 14:45
@dantti
dantti force-pushed the dantti/fix_linuxdeploy_log_include branch from 3d9d609 to f5f6ca5 Compare October 17, 2024 13:30
@dantti

dantti commented Oct 17, 2024

Copy link
Copy Markdown
Contributor Author

@TheAssassin this is ready to be merged, CI is broken due other stuff (which a few are addressed in another PR)

@dantti

dantti commented Jul 17, 2025

Copy link
Copy Markdown
Contributor Author

@TheAssassin ping

@dantti
dantti force-pushed the dantti/fix_linuxdeploy_log_include branch from 268f4d6 to 14541e8 Compare August 14, 2025 20:30
@dantti

dantti commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

rebased again

@TheAssassin

Copy link
Copy Markdown
Member

Sorry for the delay, have not had any time to review this before.

@TheAssassin

Copy link
Copy Markdown
Member

Thanks a lot!

@TheAssassin
TheAssassin merged commit b41aac6 into linuxdeploy:master Aug 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants