yasm@sniemetz: sync features accumulated since initial submission - #9055
Merged
Merged
Conversation
Fast-forwards the spices tree with changes made in the upstream YASM repo since d0ab2bd (initial submission), before layering the AMD CPU-temp fix on top in the next commit. Files changed: - applet.js: - CPU/GPU temperature alert notifications (with cooldown timers so a hot chip does not spam the notification tray each poll). - NVIDIA suspend fix — a GPU in PRIME/on-demand mode now shows as "suspended" instead of dropping off the panel with an error on read. - Icon-picker refactor: the per-tile icon picker was replaced by a per-tile display switch (icon vs label), simpler UI and fewer settings keys. - Load threshold reading: the applet now reads load-warn / load-alert as percentages (matching what the schema stores), instead of misreading them as fractions. - Various small refactors and defensive-read cleanups. - settings-schema.json: - cpu-temp-alert-notify (checkbox) — whether to raise a notification on CPU temp alert. - gpu-temp-warn / gpu-temp-alert (spinbutton, °C) — GPU temperature thresholds, previously CPU-only. - gpu-temp-alert-notify (checkbox) — same as CPU counterpart. - Minor renumbering in the GPU section keys ordering. - README.md: rewritten with a technical overview (data sources, polling cadence, why no daemon, GPU metrics via nvtop). Minimum refresh interval raised from 1 s to 3 s — sub-3-second polling makes the applet's own subprocess spawns visible in the metrics it is trying to measure. No user-visible behavior regressions expected; existing settings values remain valid under the updated schema.
Contributor
Author
|
Hi @claudiux - wasn't sure whether to submit single PR or split - opted to split. Cheers! |
claudiux
approved these changes
Sep 20, 2026
rcalixte
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast-forwards the applet with changes made upstream in the YASM repo since #8769. Prepares the tree for a follow-up bugfix PR (CPU temperature stuck at 0 on AMD hosts) that will be submitted after this lands.
What's changed
applet.jsload-warn/load-alertas percentages, matching what the schema already stores. (Previously it treated the stored 70/90 as fractions, so alerts never fired.)settings-schema.jsoncpu-temp-alert-notify(checkbox) — whether to notify on CPU temp alert.gpu-temp-warn/gpu-temp-alert(spinbutton, °C) — GPU temperature thresholds, previously CPU-only.gpu-temp-alert-notify(checkbox) — GPU counterpart of the CPU flag.README.mdnvtop.Compatibility
No user-visible behaviour regressions expected. Existing stored settings remain valid under the updated schema.
Testing
~/.xsession-errors.