[cinnamon-screenshot@hilyxx] V1.3.3 - Ready for LM23 - #1138
Merged
Conversation
* Improve compatibility with cinnamon 6.8 (Remove deprecated require() and module.exports)
Hilyxx
marked this pull request as draft
August 20, 2026 16:49
Contributor
Author
|
I relied on a comment stating that using GLib.get_user_data_dir() could cause a silent failure if the XDG_DATA_HOME variable was modified, so I changed it accordingly to follow Spices.py, which hard-coded the path as locale_inst = f'{home}/.local/share/locale'. The pull request can now be merged. |
Hilyxx
marked this pull request as ready for review
August 20, 2026 17:04
Improve compatibility with wayland and the new native cinnamon-screenshot application.
rcalixte
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.