ci: add explicit workflow permissions - #290
Merged
Merged
Conversation
Fixes both open CodeQL `actions/missing-workflow-permissions` alerts by setting a least-privilege top-level `permissions` block: - python-package.yml: `contents: read` (test-only workflow) - calibreapp-image-actions.yml: `contents: write` + `pull-requests: write`, since image-actions commits compressed images back to the PR branch and posts a summary comment. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R6goePzwRXty3vY9xTr7uz
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
=======================================
Coverage 88.65% 88.65%
=======================================
Files 3 3
Lines 291 291
=======================================
Hits 258 258
Misses 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes both open code scanning alerts (
actions/missing-workflow-permissions, medium).python-package.ymlcontents: readcalibreapp-image-actions.ymlcontents: write,pull-requests: writeWithout a top-level
permissionsblock, theGITHUB_TOKENfalls back to the repo/org default, which can be write-all. These blocks pin each workflow to least privilege.Verified both files still parse as valid YAML with the expected
permissionsvalues.🤖 Generated with Claude Code
https://claude.ai/code/session_01R6goePzwRXty3vY9xTr7uz