build(tests): standardize MapManager unit test project#2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes the MapManager unit test project naming and solution wiring so tooling (Apis.Bake) can discover it under a UnitTests family, and updates configuration path assertions to match the renamed output directory.
Changes:
- Renames the test project identity to
MapManager.UnitTestsand wires it intoMapManager.sln. - Adds the new
MapManager.UnitTestsSDK-style test project with assembly metadata and API-focused tests. - Updates config-path assertions to reference the new
MapManager.UnitTestsoutput directory.
Reviewed changes
Copilot reviewed 2 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| MapManager.UnitTests/Properties/AssemblyInfo.cs | Adds assembly metadata for the renamed test project. |
| MapManager.UnitTests/MapManager.UnitTests.csproj | Introduces the new unit test project definition and dependencies. |
| MapManager.UnitTests/Apis/ZLibTest.cs | Adds a ZLib API version test under the new project. |
| MapManager.UnitTests/Apis/ProjTest.cs | Adds a Proj API version test under the new project. |
| MapManager.UnitTests/Apis/Ogr/DriverTest.cs | Adds OGR driver enumeration tests under the new project. |
| MapManager.UnitTests/Apis/MapServerTest.cs | Adds MapServer version/support flag tests under the new project. |
| MapManager.UnitTests/Apis/GeosTest.cs | Adds a GEOS API version test under the new project. |
| MapManager.UnitTests/Apis/Gdal/DriverTest.cs | Adds GDAL driver enumeration tests under the new project. |
| MapManager.UnitTests/Apis/FontTest.cs | Adds a font listing/count test under the new project. |
| MapManager.UnitTests/Apis/CurlTest.cs | Adds a Curl API version test under the new project. |
| MapManager.UnitTests/Apis/Config/ConfigTest.cs | Updates expected output paths for config assets to the renamed project directory. |
| MapManager.sln | Updates the solution to reference MapManager.UnitTests instead of MapManager.Tests. |
Comments suppressed due to low confidence (1)
MapManager.UnitTests/Apis/Config/ConfigTest.cs:29
- These assertions hard-code a local absolute path and still reference
net461, but the renamed test project targetsnet48. SinceMapManager.Apis.Config.Defaultderives its path from the referenced assembly location, this will fail whenever the repo checkout/output path differs (and is inconsistent with the new TFM). Consider asserting against a computed expected path derived fromMapManager.Apis.Versioninstead of a hard-coded string (and apply the same approach to the other asserts in this file).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MapManager.TeststoMapManager.UnitTestsso Apis.Bake discovers it in the UnitTests familyPart of mapdojo/Xyzt#171.
Verification
git diff --checkdotnet restore MapManager.UnitTests/MapManager.UnitTests.csprojcompleted; build remains dependent on the Xyzt checkout's native GDAL SDK artifacts and is recorded in the parent adoption PR.