Skip to content

build(tests): standardize MapManager unit test project#2

Merged
bradbrowne merged 1 commit into
xyztfrom
codex/xyzt/mapmanager-unittests
Jul 23, 2026
Merged

build(tests): standardize MapManager unit test project#2
bradbrowne merged 1 commit into
xyztfrom
codex/xyzt/mapmanager-unittests

Conversation

@bradbrowne

Copy link
Copy Markdown

Summary

  • rename MapManager.Tests to MapManager.UnitTests so Apis.Bake discovers it in the UnitTests family
  • update the MapManager solution project identity and path
  • update configuration path assertions for the renamed output directory

Part of mapdojo/Xyzt#171.

Verification

  • git diff --check
  • dotnet restore MapManager.UnitTests/MapManager.UnitTests.csproj completed; build remains dependent on the Xyzt checkout's native GDAL SDK artifacts and is recorded in the parent adoption PR.

Copilot AI review requested due to automatic review settings July 23, 2026 03:28
@bradbrowne
bradbrowne merged commit 20fab98 into xyzt Jul 23, 2026
1 check passed
@bradbrowne
bradbrowne deleted the codex/xyzt/mapmanager-unittests branch July 23, 2026 03:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes the MapManager unit test project naming and solution wiring so tooling (Apis.Bake) can discover it under a UnitTests family, and updates configuration path assertions to match the renamed output directory.

Changes:

  • Renames the test project identity to MapManager.UnitTests and wires it into MapManager.sln.
  • Adds the new MapManager.UnitTests SDK-style test project with assembly metadata and API-focused tests.
  • Updates config-path assertions to reference the new MapManager.UnitTests output directory.

Reviewed changes

Copilot reviewed 2 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
MapManager.UnitTests/Properties/AssemblyInfo.cs Adds assembly metadata for the renamed test project.
MapManager.UnitTests/MapManager.UnitTests.csproj Introduces the new unit test project definition and dependencies.
MapManager.UnitTests/Apis/ZLibTest.cs Adds a ZLib API version test under the new project.
MapManager.UnitTests/Apis/ProjTest.cs Adds a Proj API version test under the new project.
MapManager.UnitTests/Apis/Ogr/DriverTest.cs Adds OGR driver enumeration tests under the new project.
MapManager.UnitTests/Apis/MapServerTest.cs Adds MapServer version/support flag tests under the new project.
MapManager.UnitTests/Apis/GeosTest.cs Adds a GEOS API version test under the new project.
MapManager.UnitTests/Apis/Gdal/DriverTest.cs Adds GDAL driver enumeration tests under the new project.
MapManager.UnitTests/Apis/FontTest.cs Adds a font listing/count test under the new project.
MapManager.UnitTests/Apis/CurlTest.cs Adds a Curl API version test under the new project.
MapManager.UnitTests/Apis/Config/ConfigTest.cs Updates expected output paths for config assets to the renamed project directory.
MapManager.sln Updates the solution to reference MapManager.UnitTests instead of MapManager.Tests.
Comments suppressed due to low confidence (1)

MapManager.UnitTests/Apis/Config/ConfigTest.cs:29

  • These assertions hard-code a local absolute path and still reference net461, but the renamed test project targets net48. Since MapManager.Apis.Config.Default derives its path from the referenced assembly location, this will fail whenever the repo checkout/output path differs (and is inconsistent with the new TFM). Consider asserting against a computed expected path derived from MapManager.Apis.Version instead of a hard-coded string (and apply the same approach to the other asserts in this file).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants