Skip to content

build(tests): classify MapManager as manual#5

Merged
bradbrowne merged 2 commits into
xyztfrom
codex/xyzt/mapmanager-manual-tests
Jul 23, 2026
Merged

build(tests): classify MapManager as manual#5
bradbrowne merged 2 commits into
xyztfrom
codex/xyzt/mapmanager-manual-tests

Conversation

@bradbrowne

Copy link
Copy Markdown

Summary

  • Rename MapManager.UnitTests to MapManager.ManualTests so Apis.Bake excludes it from automated .UnitTests discovery.
  • Keep the project in the solution for compile coverage.
  • Change the test output type to Library so the renamed xUnit project builds without a generated executable entry point.

Verification

  • dotnet build MapManager.ManualTests/MapManager.ManualTests.csproj --configuration Release --no-restore
  • Build succeeds with 0 errors; existing package/reference warnings remain.

Part of mapdojo/Xyzt#171

Copilot AI review requested due to automatic review settings July 23, 2026 04:44
@bradbrowne bradbrowne added area:build Subsystem or technical surface. topic:maintenance Cross-cutting topic. labels Jul 23, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a8dda4b9d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread MapManager.ManualTests/MapManager.ManualTests.csproj Outdated
Comment thread MapManager.ManualTests/MapManager.ManualTests.csproj Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reclassifies MapManager’s API/integration-style tests as “manual” by moving them into a renamed MapManager.ManualTests project and adjusting project settings so it still builds for compile coverage while being excluded from automated .UnitTests discovery.

Changes:

  • Introduces MapManager.ManualTests project (xUnit v3) containing API/version/config sanity checks.
  • Switches the test project output type from Exe to Library to avoid an executable entry point.
  • Adds explicit AssemblyInfo.cs (with GenerateAssemblyInfo=false) for the manual test assembly.

Reviewed changes

Copilot reviewed 1 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
MapManager.ManualTests/Properties/AssemblyInfo.cs Adds explicit assembly metadata for the manual tests project.
MapManager.ManualTests/MapManager.ManualTests.csproj Defines the manual tests project and switches output type to Library.
MapManager.ManualTests/Apis/ZLibTest.cs Adds a manual test asserting ZLib version.
MapManager.ManualTests/Apis/ProjTest.cs Adds a manual test asserting Proj version.
MapManager.ManualTests/Apis/Ogr/DriverTest.cs Adds manual assertions over OGR driver enumeration.
MapManager.ManualTests/Apis/MapServerTest.cs Adds manual tests asserting MapServer version info/support and a couple toggles.
MapManager.ManualTests/Apis/GeosTest.cs Adds a manual test asserting GEOS version.
MapManager.ManualTests/Apis/Gdal/DriverTest.cs Adds manual assertions over GDAL driver enumeration and driver path assignment.
MapManager.ManualTests/Apis/FontTest.cs Adds a manual test asserting font name count.
MapManager.ManualTests/Apis/CurlTest.cs Adds a manual test asserting Curl version.
MapManager.ManualTests/Apis/Config/ConfigTest.cs Adds manual tests asserting Default/Shared config paths.
Comments suppressed due to low confidence (1)

MapManager.ManualTests/MapManager.ManualTests.csproj:6

  • The PR description says MapManager.UnitTests was renamed to MapManager.ManualTests, but the solution still references MapManager.UnitTests\\MapManager.UnitTests.csproj (and there is no MapManager.UnitTests directory in this branch). This will break building/loading MapManager.sln unless the .sln is updated to point at the new project.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bradbrowne

Copy link
Copy Markdown
Author

Review Resolution Summary

  • Accepted the stale solution-reference finding; MapManager.sln now points to MapManager.ManualTests/MapManager.ManualTests.csproj.
  • Accepted the xUnit v3 executable-output finding; the project remains OutputType=Exe.
  • Verified the renamed project with a forced restore and dotnet build -c Release; build passed with warnings only.

@bradbrowne
bradbrowne requested a review from Copilot July 23, 2026 04:54
@bradbrowne

Copy link
Copy Markdown
Author

@copilot Please review the current HEAD 25281a5, including the solution reference and xUnit v3 executable configuration.

@bradbrowne
bradbrowne merged commit 0428317 into xyzt Jul 23, 2026
1 check passed
@bradbrowne
bradbrowne deleted the codex/xyzt/mapmanager-manual-tests branch July 23, 2026 04:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 12 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build Subsystem or technical surface. topic:maintenance Cross-cutting topic.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants