Sans spheres intensity fix - #2600
Open
Lomholy wants to merge 10 commits into
Open
Conversation
…ering penetration depth, from SANS_spheres2.comp
…tions to function
… attenuate beam on the outgoing path
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Free-form text area
Please describe what your PR is adding in terms of features or bugfixes:
The Sans_spheres comp was not matching the otherwise validated SANS_spheres2.comp in intensity, when simulated under similar circumstances. Likewise it was not matching an analytical calculation completely.
This PR adds a Sigma to the attenuation factor of the Sans_spheres component that brings it in line with the SANS_spheres2 component and the analytical calculation. This PR also adds a missing attenuation the SANS_spheres2 component, in the case that it only simulates 1 scattering event inside the sample.
Furthermore the Sans_spheres component was missing a conversion from deg to rad in its angular focusing option. This has been added with this PR.
Declaration of use of AI-tools
I used an AI to rewrite the header into a readme file.
Development OS / boundary conditions
Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
MacOS Tahoe 26.6.2
PR Checklist for contributing to McStas/McXtrace
For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:
My contribution includes patches to an existing component file
mcdocutility and rendered a reasonable documentation page for the component (please attach as screenshot in comments!)mctestutility to test one or more instruments making use of the component (please attachmcviewtestreport as screenshot in comments)mccode-clangformattool to apply the standard McCode component indentation schememcrun --c-lint"linter" and followed advice to remove most / all warnings that are raisedMy contribution includes a new instrument file
mcdocutility and rendered a reasonable documentation page for the instrument (please attach as screenshot in comments!)%Example:line to describe expected behaviourmcrun --c-lint"linter" and followed advice to remove most / all warnings that are raisedexampleshierarchy in a folder in the style ofexamples/ESS/New_stuff/New_stuff.instr