Conversation
MxKevinBeqo
requested changes
Oct 2, 2026
| ### Changed | ||
|
|
||
| - Replaced external dependency `react-native-segmented-control-tab` with in-house SegmentedControl component. | ||
| - Fixed accessibility: component now uses modern React Native accessibility props (`accessibilityRole="tab"`, `accessibilityState.selected`) instead of deprecated `accessibilityTraits` and `accessibilityComponentType`. |
Contributor
There was a problem hiding this comment.
Let's move this as part of a ### Fixed section for better clarification.
| ]} | ||
| testID={`${testID}$button-${index}`} | ||
| > | ||
| <Text numberOfLines={1} style={[textStyle, isSelected && activeTextStyle]}> |
Contributor
There was a problem hiding this comment.
There might not be a specific text for this, so let's make sure that the numberOfLines={1} does not cause text clipping on long text sizes.
| backgroundColor: "transparent", | ||
| opacity: pressed ? 0.6 : 1 | ||
| }, | ||
| buttonStyle, |
Contributor
There was a problem hiding this comment.
This note is part of automatic LLM review so I am not entirely sure of validity. But, posting it here so that at least we test it, since it might pass the maestro screenshot comparison threshold.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅ ❌Feature specific
Please remove unnecessary emojis and sections and this comment before proceeding
This PR contains
What is the purpose of this PR?
...
Relevant changes
Please add a high level explanation of what was changed and how the initial problem was solved
What should be covered while testing?
...
Extra comments (optional)
Please add extra comments or delete the section if not required