Skip to content

Add TypeScript infrastructure and typings - #344

Draft
lundibundi wants to merge 1 commit into
masterfrom
ts-typings
Draft

Add TypeScript infrastructure and typings#344
lundibundi wants to merge 1 commit into
masterfrom
ts-typings

Conversation

@lundibundi

Copy link
Copy Markdown
Member
  • code is properly formatted (npm run fmt)
  • tests are added/updated
  • documentation is updated (npm run doc to regenerate documentation based on comments)
  • description of changes is added under the Unreleased header in CHANGELOG.md

Since I always have the Iterator typings in my TS projects anyway I guess we could add them here, I'd support these to the best of my ability.
Not sure what would be the best way to go for other modules but since they rarely change I guess we could just type them as well. I would not change the process of PRing changes to include TS as people may not be familiar with it but rather someone updates them as we go forward (preferably before release πŸ˜„ ).

/cc @belochub

Comment thread package.json Outdated
@lundibundi

Copy link
Copy Markdown
Member Author

@tshemsedinov @nechaido @belochub @SemenchenkoVitaliy this is waiting for feedback (in general) to decide whether to go on with it. If we approve this idea/approach I could go on adding typings for other modules in common.
(I guess if you're fine with it you can just πŸ‘ this comment, and otherwise comment)

@tshemsedinov

Copy link
Copy Markdown
Member

I believe we need ts typings ASAP, tkanks for this initiative πŸ‘ @lundibundi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants