[Experiment] Code Review with BCQuality plugin - #759
Draft
haoranpb wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables BCQuality for AL code-review experiments.
Changes:
- Replaces
/reviewwith the BCQuality review skill. - Enables the pinned BCQuality plugin.
Comments suppressed due to low confidence (2)
src/bcbench/agent/shared/config.yaml:116
- This toggle is global, not code-review-specific: both agent runners call
resolve_config_plugins(...)unconditionally for every category, and the evaluation workflows default tobug-fix. As a result, bug-fix and test-generation runs will also clone/load BCQuality and be recorded as plugin experiments, contrary to this PR's code-review-only experiment scope. Gate this plugin byEvaluationCategory.CODE_REVIEWor supply a category-specific experiment configuration.
enabled: true
src/bcbench/agent/shared/config.yaml:54
- Invoking this skill introduces an incompatible output contract. The pinned BCQuality skill mandates a findings-report object whose entries use
messageplus nestedlocation.file/location.line, whileparse_review_output()only recognizes top-levelfile/line_startandbodyfields. If the skill follows its own contract, every finding is silently skipped and the evaluation records an empty review. Add an explicit BCQuality-to-benchmark adapter (or parser support) rather than relying on the model to violate the skill contract and rewrite the shape.
/bcquality-al-review
| path: "." | ||
| - name: "BCQuality" | ||
| enabled: false | ||
| enabled: true |
|
|
||
| code-review-template: | | ||
| /review | ||
| /bcquality-al-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try experimenting with BCQuality plugin, for code review skill