Allow access to the inner accessor in BetaAccessor. - #1391
Merged
Conversation
Mark Hildebrand (hildebrandmw)
requested review from
a team
and
a lite review from Copilot
September 11, 2026 18:40
Copilot started reviewing on behalf of
Mark Hildebrand (hildebrandmw)
September 11, 2026 18:41
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Adds a public mutable accessor to BetaAccessor for custom metric reporting and accessor tunneling.
Changes:
- Adds the documented
BetaAccessor::inner()method.
File summaries
| File | Summary |
|---|---|
diskann-providers/src/model/graph/provider/layers/betafilter.rs |
Exposes the wrapped accessor through a public method. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Aditya Krishnan (arkrishn94)
approved these changes
Sep 11, 2026
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1391 +/- ##
==========================================
- Coverage 92.57% 92.56% -0.01%
==========================================
Files 522 522
Lines 101105 101108 +3
==========================================
- Hits 93596 93595 -1
- Misses 7509 7513 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Jack Moffitt (metajack)
approved these changes
Sep 11, 2026
Mark Hildebrand (hildebrandmw)
added a commit
that referenced
this pull request
Sep 11, 2026
This change is backwards compatible with 0.58.0 outside of the following breaking changes to `diskann-disk`: * Public function `diskann_disk::search::pq::quantizer_preprocess` removed. It has been removed and its logic folded into a private `PQScratch::prepare_query`/`preprocess_query` method as part of migrating disk PQ flat scan onto the new flat-scan API (#1341). ## What's Changed * Migrate disk PQ flat scan to flat API by @partychen in #1341 * Bump the github-actions group across 1 directory with 3 updates by @dependabot[bot] in #1371 * [diskann-garnet] Implement `continue_search()` by @metajack in #1357 * [diskann-wide] Add more 64-bit neon types by @hildebrandmw in #1377 * Allow access to the inner accessor in `BetaAccessor`. by @hildebrandmw in #1391 * [multi vector] Distance Kernels by @hildebrandmw in #1368 **Full Changelog**: v0.58.0...v0.59.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for enabling tunneling into the inner accessor for custom metric reporting. We aren't really exposing any additional members since
Unwrapalready allows direct access to the inner accessor.