feat(kernel): enable x86 ThinkPad ACPI - #18302
Conversation
8cdcc7e to
7df9807
Compare
There was a problem hiding this comment.
🟡 Not ready to approve
The committed kernel render failed and deleted the rendered spec and required build inputs.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Enables ThinkPad ACPI support for the x86_64 kernel, including required ACPI power dependencies and a manual package-release bump. However, kernel rendering failed and removed the rendered build inputs.
Changes:
- Enables
CONFIG_THINKPAD_ACPI=m, ACPI AC, and ACPI battery support. - Bumps the kernel release to
1.12and refreshes its lock fingerprint. - Introduces a failed-render marker while deleting the rendered kernel output.
File summaries
| File | Description |
|---|---|
base/comps/kernel/6.18-x86_64-azl.config |
Enables ThinkPad ACPI and dependencies. |
base/comps/kernel/kernel.azl.macros |
Bumps the manual package release. |
base/comps/kernel/kernel.spec |
Adds the release changelog entry. |
locks/kernel.lock |
Refreshes the component fingerprint. |
specs/k/kernel/RENDER_FAILED |
Records the unsuccessful render. |
specs/k/kernel/Makefile.rhelver |
Removed by the failed render. |
specs/k/kernel/Module.kabi_aarch64 |
Removed by the failed render. |
specs/k/kernel/Module.kabi_dup_aarch64 |
Removed by the failed render. |
specs/k/kernel/Module.kabi_dup_ppc64le |
Removed by the failed render. |
specs/k/kernel/Module.kabi_dup_riscv64 |
Removed by the failed render. |
specs/k/kernel/Module.kabi_dup_s390x |
Removed by the failed render. |
specs/k/kernel/Module.kabi_dup_x86_64 |
Removed by the failed render. |
specs/k/kernel/Module.kabi_ppc64le |
Removed by the failed render. |
specs/k/kernel/Module.kabi_riscv64 |
Removed by the failed render. |
specs/k/kernel/Module.kabi_s390x |
Removed by the failed render. |
specs/k/kernel/Module.kabi_x86_64 |
Removed by the failed render. |
specs/k/kernel/Patchlist.changelog |
Removed by the failed render. |
specs/k/kernel/README.rst |
Removed by the failed render. |
specs/k/kernel/azurelinux-ca-20230216.pem |
Removed by the failed render. |
specs/k/kernel/check-kabi |
Removed by the failed render. |
specs/k/kernel/def_variants.yaml.fedora |
Removed by the failed render. |
specs/k/kernel/def_variants.yaml.rhel |
Removed by the failed render. |
specs/k/kernel/dracut-virt.conf |
Removed by the failed render. |
specs/k/kernel/filtermods.py |
Removed by the failed render. |
specs/k/kernel/flavors |
Removed by the failed render. |
specs/k/kernel/gating.yaml |
Removed by the failed render. |
specs/k/kernel/generate_all_configs.sh |
Removed by the failed render. |
specs/k/kernel/kernel-local |
Removed by the failed render. |
specs/k/kernel/kernel.azl.macros |
Removed by the failed render. |
specs/k/kernel/kernel.sbat.template |
Removed by the failed render. |
specs/k/kernel/kmod-nvidia-open-modprobe.conf |
Removed by the failed render. |
specs/k/kernel/kmod-nvidia-open.inc |
Removed by the failed render. |
specs/k/kernel/kvm_stat.logrotate |
Removed by the failed render. |
specs/k/kernel/linux-kernel-test.patch |
Removed by the failed render. |
specs/k/kernel/merge.py |
Removed by the failed render. |
specs/k/kernel/mod-denylist.sh |
Removed by the failed render. |
specs/k/kernel/mod-sign.sh |
Removed by the failed render. |
specs/k/kernel/partial-clang-debug-snip.config |
Removed by the failed render. |
specs/k/kernel/partial-clang-snip.config |
Removed by the failed render. |
specs/k/kernel/partial-clang_lto-aarch64-debug-snip.config |
Removed by the failed render. |
specs/k/kernel/partial-clang_lto-aarch64-snip.config |
Removed by the failed render. |
specs/k/kernel/partial-clang_lto-x86_64-debug-snip.config |
Removed by the failed render. |
specs/k/kernel/partial-clang_lto-x86_64-snip.config |
Removed by the failed render. |
specs/k/kernel/partial-kgcov-debug-snip.config |
Removed by the failed render. |
specs/k/kernel/partial-kgcov-snip.config |
Removed by the failed render. |
specs/k/kernel/process_configs.sh |
Removed by the failed render. |
specs/k/kernel/rpminspect.yaml |
Removed by the failed render. |
specs/k/kernel/sources |
Removed by the failed render. |
specs/k/kernel/uki-addons.sbat.template |
Removed by the failed render. |
specs/k/kernel/uki.sbat.template |
Removed by the failed render. |
specs/k/kernel/uki_addons.json |
Removed by the failed render. |
specs/k/kernel/uki_create_addons.py |
Removed by the failed render. |
specs/k/kernel/x509.genkey.centos |
Removed by the failed render. |
specs/k/kernel/x509.genkey.fedora |
Removed by the failed render. |
specs/k/kernel/x509.genkey.rhel |
Removed by the failed render. |
Review details
- Files reviewed: 6/7 changed files
- Comments generated: 0
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
There was a problem hiding this comment.
🟡 Human review recommended
Kernel configuration changes require confirmed build and hardware smoke-test results before approval.
Review details
- Files reviewed: 6/7 changed files
- Comments generated: 0 new
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
7df9807 to
9427666
Compare
|
This PR is ThinkPad ACPI only. ACPI AC/battery are enabled solely because thinkpad_acpi depends on them. Regenerated the fragment for process_configs -n. |
There was a problem hiding this comment.
🟡 Not ready to approve
CONFIG_ACPI_AC is enabled as a claimed dependency even though it is independent of THINKPAD_ACPI.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
Suppressed comments (1)
base/comps/kernel/6.18-x86_64-azl.config:638
CONFIG_ACPI_ACis not a dependency ofTHINKPAD_ACPI; the pinned kernel Kconfig depends onACPI_ECandACPI_BATTERY, while AC-adapter support is independent. This therefore enables an extra built-in driver beyond the stated ThinkPad dependency change. Please restore the previous setting unless AC-adapter support is intentionally in scope, in which case document that separate rationale.
CONFIG_ACPI_AC=y
- Files reviewed: 6/7 changed files
- Comments generated: 0 new
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Enable `CONFIG_THINKPAD_ACPI=m` for x86_64. The x86_64 configuration already builds X86 platform device support. `thinkpad_acpi` depends on `CONFIG_ACPI_BATTERY`, so ACPI battery is enabled as a required dependency. The driver is built as a module. This option is x86-specific.
9427666 to
26fe619
Compare
|
Dropped CONFIG_ACPI_AC. thinkpad_acpi only depends on ACPI_BATTERY (plus ACPI_EC, which is already on). Specs are restored from the component inputs; the earlier failed render is gone. |
There was a problem hiding this comment.
🟡 Human review recommended
The configuration is internally consistent, but a kernel output change requires human confirmation of the mandatory full build and smoke-testing results.
Review details
- Files reviewed: 6/7 changed files
- Comments generated: 0 new
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Enable
CONFIG_THINKPAD_ACPI=mfor x86_64.The x86_64 configuration already builds X86 platform device support.
thinkpad_acpidepends onCONFIG_ACPI_BATTERY, so ACPI battery is enabled as a required dependency. The driver is built as a module.This option is x86-specific.