fix: ghc-zip-archive - remove flagged files - #18602
Closed
Andrew Phelps (anphel31) wants to merge 1 commit into
Closed
fix: ghc-zip-archive - remove flagged files#18602Andrew Phelps (anphel31) wants to merge 1 commit into
Andrew Phelps (anphel31) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an encrypted test fixture from ghc-zip-archive to satisfy signing-pipeline scanning requirements.
Changes:
- Adds an archive overlay to remove the fixture.
- Disables the package test suite.
- Refreshes generated sources, spec, and lock state.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
base/comps/ghc-zip-archive/ghc-zip-archive.comp.toml |
Defines source and spec overlays. |
base/comps/components.toml |
Moves the customized component out of the inline list. |
locks/ghc-zip-archive.lock |
Refreshes the component fingerprint. |
specs/g/ghc-zip-archive/ghc-zip-archive.spec |
Records the generated test toggle and release bump. |
specs/g/ghc-zip-archive/sources |
Pins the repacked archive checksum. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+21
to
+22
| regex = '^%bcond tests 1$' | ||
| replacement = '%bcond tests 0' |
| filename = "zip-archive-0.4.3.2.tar.gz" | ||
| hash = "ebf8adf1972fac04c7ba1eb612b7315e06bc15e6393225e412ee9c75de12334116fd1880a3a1e2b960faaf060370266004c32532a0a9c80ffd4dbef863e74fc3" | ||
| hash-type = "SHA512" | ||
| origin = { type = "overlay" } |
Andrew Phelps (anphel31)
force-pushed
the
anphel/esrp-fix-ghc-zip-archive
branch
from
August 25, 2026 09:30
470984b to
3c7db7c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
base/comps/ghc-zip-archive/ghc-zip-archive.comp.toml:44
- The new
overlayorigin is supported by the pinned azldev, but it is missing from this repository's authoritative schema:external/schemas/azldev.schema.json:716-719permits onlydownloadandcustom. As a result, schema-aware validation and editor tooling will reject this component definition. Please regenerate and commit the schema with the pinned azldev sooverlayis included.
origin = { type = "overlay" }
Andrew Phelps (anphel31)
force-pushed
the
anphel/esrp-fix-ghc-zip-archive
branch
from
August 26, 2026 00:48
3c7db7c to
0f3b95b
Compare
Comment on lines
+9
to
+11
| type = "file-remove" | ||
| archive = "zip-archive-0.4.3.2.tar.gz" | ||
| file = "tests/zip_with_password.zip" |
The zip-archive test suite ships tests/zip_with_password.zip, a password-protected (encrypted) fixture that fails the package-signing scan and blocks signing. Remove it with an azldev archive overlay (file-remove) that deterministically repacks the source tarball, and drop the three test cases that read it (testExtractFilesFailOnEncrypted, testPasswordProtectedRead, testIncorrectPasswordRead) via file-search-replace overlays so the rest of the Cabal suite (%bcond tests 1) keeps running. Test-only, not shipped in any binary RPM.
Andrew Phelps (anphel31)
force-pushed
the
anphel/esrp-fix-ghc-zip-archive
branch
from
August 26, 2026 04:20
0f3b95b to
e7045df
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
base/comps/ghc-zip-archive/ghc-zip-archive.comp.toml:11
- Remove this fixture from the Cabal manifest as well.
specs/g/ghc-zip-archive/zip-archive-0.4.3.2.cabal:44still lists it underExtra-Source-Files, and%prepreplaces the archive's Cabal file with that separateSource1(ghc-zip-archive.spec:31-32,137-138). The resulting source tree therefore advertises a nonexistent file, so Cabal source-distribution/package checks can fail. Add an overlay for the loose Cabal source and refresh its generated hash, lock, and rendered sources.
file = "tests/zip_with_password.zip"
Member
Author
|
Superseded by #18624 (branch renamed; same change). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove a password-protected (encrypted) test fixture from ghc-zip-archive and drop the three test cases that read it.
The zip-archive test suite ships
tests/zip_with_password.zip, a password-protected (encrypted) fixture. The package-signing scan can't inspect encrypted archives and rejects the .src.rpm, blocking signing. The file is test-only and not shipped in any binary RPM.file-remove) removes the file and repacks the tarball; the post-overlay hash is pinned via asource-filesentry (origin = { type = "overlay" }).file-search-replaceoverlays drop only the three cases that read it (testExtractFilesFailOnEncrypted,testPasswordProtectedRead,testIncorrectPasswordRead), keeping%bcond tests 1and the rest of the Cabal suite running.azldev comp render --check-onlyreports no drift.