fix: minizip-ng - remove flagged files - #18603
Closed
Andrew Phelps (anphel31) wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes encrypted minizip-ng fuzz fixtures that block ESRP signing.
Changes:
- Adds archive overlays to remove fixtures and related CTest cases.
- Pins the repacked archive and refreshes generated state.
- Moves minizip-ng into a dedicated component definition.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
base/comps/minizip-ng/minizip-ng.comp.toml |
Defines archive overlays and repacked source metadata. |
base/comps/components.toml |
Removes the former inline component entry. |
locks/minizip-ng.lock |
Refreshes the component fingerprint. |
specs/m/minizip-ng/sources |
Records the repacked archive hash. |
specs/m/minizip-ng/minizip-ng.spec |
Updates generated release and changelog data. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| filename = "minizip-ng-4.0.10.tar.gz" | ||
| hash = "9cb38550aec5f7983d8f3afd7ed376a05c9d0d4347507f8aea426d75da2d5d90555a671da9dbdd7982d3916f0371b4cb1cb647ed2a641e8256202cd8d4737fd7" | ||
| hash-type = "SHA512" | ||
| origin = { type = "overlay" } |
Andrew Phelps (anphel31)
force-pushed
the
anphel/esrp-fix-minizip-ng
branch
from
August 26, 2026 00:48
3686c8e to
632530f
Compare
minizip-ng ships two password-protected (encrypted) libFuzzer seed-corpus zips (test/fuzz/unzip_fuzzer_seed_corpus/encrypted_pkcrypt.zip and encrypted_wzaes.zip) that fail the package-signing scan and block signing. Remove both with an azldev archive overlay (file-remove) that deterministically repacks the source tarball, and drop the two CTest cases (unzip-pkcrypt, unzip-wzaes) that read them via a file-search-replace overlay on CMakeLists.txt. The spec builds tests but has no %check; the files/cases are test-only and not shipped in any binary RPM.
Andrew Phelps (anphel31)
force-pushed
the
anphel/esrp-fix-minizip-ng
branch
from
August 26, 2026 04:26
632530f to
94fce90
Compare
Andrew Phelps (anphel31)
changed the title
Member
Author
|
Superseded by #18625 (branch renamed; same change). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove two password-protected (encrypted) libFuzzer seed-corpus zips from minizip-ng and drop the two CTest cases that read them.
minizip-ng ships
test/fuzz/unzip_fuzzer_seed_corpus/encrypted_pkcrypt.zipandencrypted_wzaes.zip. The package-signing scan can't inspect encrypted archives and rejects the .src.rpm, blocking signing. The files are test-only and not shipped in any binary RPM.file-remove, globencrypted_*.zip) removes both and repacks the tarball; the post-overlay hash is pinned viaorigin = { type = "overlay" }.file-search-replaceoverlay onCMakeLists.txtdrops only the two dependent CTest cases (unzip-pkcrypt,unzip-wzaes); the rest are untouched. The spec builds tests but has no%check.azldev comp render --check-onlyreports no drift.