Address runtime review comments

Fix printf-style logging arguments for scheduled upload delays and queued worker task pointers.

Ensure the blocking cancel test releases the dispatcher before failing so async futures cannot hang the test runner.

Files changed:

- lib/pal/WorkerThread.cpp

- lib/tpm/TransmissionPolicyManager.cpp

- tests/unittests/TransmissionPolicyManagerTests.cpp

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: bmehta001

lib/pal/WorkerThread.cpp

@@ -109,10 +109,10 @@ namespace PAL_NS_BEGIN {
 
         void Queue(MAT::Task* item) final
         {
-            LOG_INFO("queue item=%p", &item);
+            LOG_INFO("queue item=%p", static_cast<void*>(item));
             LOCKGUARD(m_lock);
             if (m_shuttingDown) {
-                LOG_WARN("Dropping queued task %p during shutdown", item);
+                LOG_WARN("Dropping queued task %p during shutdown", static_cast<void*>(item));
                 delete item;
                 return;
             }
@@ -298,4 +298,3 @@ namespace PAL_NS_BEGIN {
 } PAL_NS_END
 
 #endif
-

lib/tpm/TransmissionPolicyManager.cpp

@@ -115,7 +115,9 @@ namespace MAT_NS_BEGIN {
         {
             if (delay.count() < 0 || m_timerdelay.count() < 0)
             {
-                LOG_TRACE("Negative delay(%d) or m_timerdelay(%d), no upload", delay.count(), m_timerdelay.count());
+                LOG_TRACE("Negative delay(%lld) or m_timerdelay(%lld), no upload",
+                    static_cast<long long>(delay.count()),
+                    static_cast<long long>(m_timerdelay.count()));
                 return true;
             }
             if (m_scheduledUploadAborted)

tests/unittests/TransmissionPolicyManagerTests.cpp

@@ -766,7 +766,12 @@ TEST_F(TransmissionPolicyManagerTests, ForceScheduleRetainsImmediateUploadWhenCa
         blockingTpm.scheduleUploadParent(std::chrono::milliseconds{}, EventLatency_RealTime, true);
     });
 
-    ASSERT_TRUE(dispatcher.WaitForCancel(std::chrono::milliseconds{ 250 }));
+    if (!dispatcher.WaitForCancel(std::chrono::milliseconds{ 250 }))
+    {
+        dispatcher.ReleaseCancel();
+        forceSchedule.get();
+        FAIL() << "Timed out waiting for cancel to block";
+    }
 
     auto delayedSchedule = std::async(std::launch::async, [&blockingTpm]() {
         blockingTpm.scheduleUploadParent(std::chrono::milliseconds{ 1000 }, EventLatency_Normal, false);