Update C++, C# and Python Examples - #1664
Merged
Merged
Conversation
Sayan Shaw (sayanshaw24)
marked this pull request as ready for review
July 30, 2025 00:58
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Baiju Meswani (baijumeswani)
requested review from
aciddelgado,
Abhishek Jindal (ajindal1) and
kunal-vaishnavi
July 30, 2025 17:55
Baiju Meswani (baijumeswani)
previously approved these changes
Jul 30, 2025
Baiju Meswani (baijumeswani)
enabled auto-merge (squash)
July 30, 2025 18:11
Contributor
|
Can we update the Whisper examples to use the chat template? |
Collaborator
Author
After discussion with Baiju Meswani (@baijumeswani) we decided to not use the whisper chat template functionality for the examples, because specifically for our examples itself, the chat template functionality (just appending message contents) does not make sense - we do not need it. Can give you more context offline. |
Abhishek Jindal (ajindal1)
approved these changes
Jul 30, 2025
Abhishek Jindal (ajindal1)
left a comment
Abhishek Jindal (ajindal1)
left a comment
Contributor
There was a problem hiding this comment.
LGTM, it looks cleaner with the content and ApplyChatTemplate.
Baiju Meswani (baijumeswani)
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Updates examples to now use ApplyChatTemplate, including in multimodal cases as it now supports multimodal templating with a Minja-powered C++ templating engine.
Note that we decided not to use the newly added whisper chat template functionality (microsoft/onnxruntime-extensions#981) for the examples, because specifically for our examples itself, the chat template functionality (just appending message contents) does not make sense - we do not need it.
Validation