Jacdac radio conflict (proxy mode) - #11498
Open
thomasjball wants to merge 5 commits into
Open
Conversation
…sses jacdac messages
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Jacdac/radio interaction issue in the simulator by ensuring that only the primary (first) micro:bit simulator frame participates in Jacdac message traffic, preventing unintended proxy-mode behavior when additional simulator frames are spawned.
Changes:
- Removed legacy/temporary “newJacdacSimulator” gating logic for Jacdac message simulator startup.
- Added filtering so Jacdac
messagepackettraffic is ignored from non-primary micro:bit frames and not forwarded to other micro:bit frames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR fixes the issue jacdac/jacdac#68. The fix is to allow only the first microbit sim to send and receive Jacdac messages. This prevents the proxy mode from engaging when a radio message is sent creating a second microbit sim, which will neither receive/send jacdac messages.