Skip to content

chat: Make customizations multi-root workspace aware - #335592

Draft
Jessie Houghton (houghj16) wants to merge 3 commits into
mainfrom
agents/customizations-multi-root-workspace
Draft

Jessie Houghton (houghj16) wants to merge 3 commits into
mainfrom
agents/customizations-multi-root-workspace

Conversation

@houghj16

@houghj16 Jessie Houghton (houghj16) commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • split workspace-backed customization sections by folder when two or more workspace folders are active
  • keep the existing single-folder and empty-workspace presentation unchanged
  • scope manual and AI-assisted customization creation to the workspace folder where the section action was invoked
  • scope hook discovery, existing hook files, and hook destinations to the selected workspace folder
  • reuse the source-line and MCP behavior already available on main instead of duplicating it

Customization pages

Agents, Skills, Instructions, Hooks, and Prompts

In a multi-root workspace, each folder now has its own named section instead of contributing to one combined Workspace section. Items are assigned using their containing workspace folder.

Section-level creation actions carry that folder through manual creation, root-file creation, hook configuration, and Generate with AI. Location pickers only offer destinations belonging to the selected folder.

In an empty or single-folder workspace, these pages continue to use the existing Workspace section and unscoped creation flow.

Plugins

The workspace-scoped Plugins section is split into named workspace-folder sections in multi-root workspaces. User, Remote Session, and Available sections are unchanged.

MCP Servers and row source labels

This PR does not change MCP row presentation or customization-row source labels. It uses the implementations that have since landed on main.

Testing

  • npm run compile-client — passed
  • scripts\test.bat src\vs\workbench\contrib\chat\test\browser\aiCustomization\aiCustomizationListWidget.test.ts src\vs\workbench\contrib\chat\test\browser\aiCustomization\customizationCreatorService.test.ts src\vs\workbench\contrib\chat\test\browser\aiCustomization\pluginListWidget.test.ts src\vs\workbench\contrib\chat\test\browser\promptSyntax\hookActions.test.ts — 66 passing
  • targeted ESLint over all 14 changed TypeScript files — passed
  • npm run valid-layers-check — passed
  • git diff --check — passed

Fixes #332290
Fixes #333755
Addresses #332543

Copilot AI balanced review requested due to automatic review settings September 10, 2026 23:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

AI generation remains unscoped, and source/description information has accessibility and remote-workspace regressions.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 3 Medium severity

New issues introduced by this change (3)
Severity Finding
Medium severity src/​vs/​workbench/​contrib/​chat/​browser/​aiCustomization/​aiCustomizationItemSource.ts — Preserve source paths for remote workspace files
Medium severity src/​vs/​workbench/​contrib/​chat/​browser/​aiCustomization/​aiCustomizationListWidget.ts — Propagate the originating folder to AI generation
Medium severity src/​vs/​workbench/​contrib/​chat/​browser/​aiCustomization/​mcpListWidget.ts — Expose MCP provenance in the row's ARIA label
What changed in this PR

Makes AI customizations multi-root aware by grouping items per workspace folder and scoping manual creation flows.

Changes:

  • Adds per-folder customization sections and source paths.
  • Scopes manual customization and hook creation.
  • Adds MCP provenance and updated tests/fixtures.
File Description
aiCustomizationManagementEditor.fixture.ts Adds MCP source fixtures.
hookActions.test.ts Tests workspace hook filtering.
mcpListWidget.test.ts Tests provenance and hover text.
customizationCreatorService.test.ts Tests folder-scoped creation locations.
aiCustomizationListWidget.test.ts Tests grouping, paths, and creation context.
hookActions.ts Scopes hook selection and creation.
mcpListWidget.ts Displays MCP source provenance.
customizationCreatorService.ts Filters and labels creation destinations.
aiCustomizationManagementEditor.ts Propagates workspace-folder context.
aiCustomizationListWidgetUtils.ts Uses filenames as secondary text.
aiCustomizationListWidget.ts Adds per-folder grouping and actions.
aiCustomizationItemSource.ts Removes workspace prefixes from labels.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/vs/workbench/contrib/chat/browser/aiCustomization/mcpListWidget.ts Outdated
Group workspace customizations by folder, scope creation flows to the originating workspace, and consistently show source provenance in customization rows while moving descriptions to hovers.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve workspace context for generated customizations, support remote workspace source labels, and expose MCP provenance to screen readers.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Split workspace-backed customization and plugin groups by folder only in multi-root workspaces, while preserving the existing single-root presentation and scoping creation destinations to the selected folder.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@houghj16
Jessie Houghton (houghj16) force-pushed the agents/customizations-multi-root-workspace branch from 0a7515d to f2163be Compare October 5, 2026 19:15

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants