fix(extensions): re-run the restart-required query when the Show link is clicked again

[Irish Joseph (Irish-Joseph)]

Description

Fixes #321178

When extensions are updated in the background, the Extensions view shows a
banner like "2 extensions require a restart to take effect. Show". Clicking
Show filters the list with the @restartrequired query.

After more extensions are updated, the banner increments (e.g. to 4), but
the list still shows only the original 2. Clicking Show again does nothing,
and only clearing the filter and clicking Show once more reveals all 4
extensions (as reported in the issue, still reproducible on 1.136.1).

Root cause — ExtensionsViewPaneContainer.search() only sets the search
box value when it differs from the current one:

search(value: string): void {
    if (this.searchBox && this.searchBox.getValue() !== value) {
        this.searchBox.setValue(value);
    }
}

The first Show click puts @restartrequired into the search box, which
triggers the search. A second click requests the same value, so nothing is
set and no search is re-run — the list keeps the stale result.

Fix

• search() accepts an optional refresh flag: when the search box already
  holds the requested value and refresh is set, the query is re-run
  (doSearch(true)) instead of being a no-op.
• The Show link (mouse click and Enter/Space key handling) passes
  refresh: true.
• The refresh flag is threaded through doSearch() →
  showExtensionsViews() → ExtensionsListView.show(query, refresh), which
  discards the previous query result (including its change watcher) and
  re-queries. (Previously the flag was dropped, so the list view's existing
  refresh support was unreachable from the viewlet.)

Testing

Added extensionsRestartRequiredView.test.ts which drives the real
ExtensionsWorkbenchService + ExtensionsListView and the
ExtensionsViewPaneContainer.search() entry point, simulating extension
updates that are installed while the previous version is still running (the
exact condition that puts extensions into the restart-required state):

• search() with refresh re-runs an already active query (#321178) — the
  regression test. Fails without the fix (the re-click never re-runs the
  search) and passes with it.

• re-running the same query with refresh picks up newly restart-required extensions — the list view re-query contract the fix
  relies on (1 extension → update → re-run with refresh → 2 extensions).

• the @restartrequired list updates when more extensions require a restart
  — the existing change-watcher live-update path still works.

• The full extensionsViews.test.ts (141 tests) and
  extensionsWorkbenchService.test.ts (214 tests) suites still pass.

• The touched files type-check cleanly under the repository's strict
  TypeScript settings.

[Irish Joseph (Irish-Joseph)]

@microsoft-github-policy-service agree

[Copilot]

Copilot review overview

🟡 Changes recommended

The test fixture uses the wrong install operation and does not verify refresh propagation through the container.

Review effort: Balanced
Findings: 2

Open (2)

• Use InstallOperation.Update in the update-event fixture · New
• Test refresh forwarding from doSearch through showExtensionsViews · New

What changed in this PR

Fixes stale @restartrequired extension results when users click Show repeatedly.

Changes:

• Adds refresh-aware extension searches.
• Propagates refresh requests to extension list views.
• Adds restart-required regression tests.

File	Description
extensionsRestartRequiredView.test.ts	Tests restart-required refresh behavior.
extensions.ts	Extends the search API with a refresh flag.
extensionsViewlet.ts	Re-runs and propagates same-query refreshes.

---

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.