Report memory metadata in winml sys JSON - #1312
Open
Yue Sun (KayMKM) wants to merge 2 commits into
Open
Conversation
Qiong Wu (qiowu) (DingmaomaoBJTU)
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the JSON schema additions and memory probes. The new fields are scoped correctly to the full system/device report, but there are two blocking issues: the current head fails required mypy, and the exposed GPU capacity is sourced from a 32-bit WMI field that truncates/caps modern GPU memory. Details inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
winml sys --format jsonpayloadValidation
uv run --frozen ruff check --fix src/winml/modelkit/commands/sys.py tests/e2e/test_sys_e2e.py tests/unit/commands/test_sys_device_info.pyuv run --frozen pytest tests/unit/commands/test_sys_device_info.py -q(11 passed)uv run --frozen pytest tests/e2e/test_sys_e2e.py -m e2e -q(20 passed)