Skip to content

Report memory metadata in winml sys JSON - #1312

Open
Yue Sun (KayMKM) wants to merge 2 commits into
mainfrom
yuesu/add-sys-memory-metadata
Open

Report memory metadata in winml sys JSON#1312
Yue Sun (KayMKM) wants to merge 2 commits into
mainfrom
yuesu/add-sys-memory-metadata

Conversation

@KayMKM

Copy link
Copy Markdown
Contributor

Summary

  • add a versioned schema marker and installed physical memory to the full winml sys --format json payload
  • expose dedicated GPU memory in device details when Windows reports it
  • document the JSON memory fields and cover best-effort probe behavior with unit and hardware-backed E2E tests

Validation

  • uv run --frozen ruff check --fix src/winml/modelkit/commands/sys.py tests/e2e/test_sys_e2e.py tests/unit/commands/test_sys_device_info.py
  • uv run --frozen pytest tests/unit/commands/test_sys_device_info.py -q (11 passed)
  • uv run --frozen pytest tests/e2e/test_sys_e2e.py -m e2e -q (20 passed)

@KayMKM
Yue Sun (KayMKM) requested a review from a team as a code owner August 14, 2026 08:59

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the JSON schema additions and memory probes. The new fields are scoped correctly to the full system/device report, but there are two blocking issues: the current head fails required mypy, and the exposed GPU capacity is sourced from a 32-bit WMI field that truncates/caps modern GPU memory. Details inline.

Comment thread src/winml/modelkit/commands/sys.py
Comment thread src/winml/modelkit/commands/sys.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants