fix(sort): avoid int64 overflow comparing large integers#2771
Open
maximilize wants to merge 1 commit into
Open
fix(sort): avoid int64 overflow comparing large integers#2771maximilize wants to merge 1 commit into
maximilize wants to merge 1 commit into
Conversation
The int/int comparator returned int(lhs - rhs); the int64 subtraction overflows for large-magnitude values, giving the wrong sign. Compare directly instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
sortorders large-magnitude integers incorrectly:why
The int/int branch of the sort comparator (
pkg/yqlib/operator_sort.go) returnsint(lhsNum - rhsNum). The subtraction is done inint64and overflows when the difference exceeds the int64 range (5e18 - (-5e18) = 1e19wraps negative), so the comparator reports the wrong sign.fix
Compare directly (
</>) instead of subtracting, mirroring the float branch just below. Regression scenario added (skipDoc).