feat(favorites): add dashboard favorites - #214
Open
kevjablonski wants to merge 3 commits into
Open
Conversation
Introduces UserConfig and favorite relationships for Companies and Boundaries. Adds APIs to manage favorites, dashboard favorites display, favorite indicators and toggles on Company/Boundary pages, and navigation to favorited items. Includes migrations and seed updates to initialize user configuration for existing and new users. Signed-off-by: Kevin Jablonski <kevjablonski@gmail.com>
Extracts shared favorite management into a reusable utility to reduce duplicate API code.
Removes the UserConfig dependency and associates favorites directly with Users. Updates migrations, models, APIs, and frontend to simplify favorite management while preserving existing functionality. Signed-off-by: Kevin Jablonski <kevjablonski@gmail.com>
|
markcrivera
requested changes
Aug 18, 2026
| })), | ||
| ]; | ||
| } else if (error.value) { | ||
| console.error("Failed to load user config:", error.value); |
| const aliasStore = useAliasStore(); | ||
| const { data: config, error } = await useFetch("/api/favorites/list"); | ||
| const boundaryTerm = aliasStore.BoundaryAlias; | ||
| const companyTerm = aliasStore.CompanyAlias; |
Collaborator
There was a problem hiding this comment.
Getting lint errors that this isn't used.
| import { useAliasStore } from "~/stores/AliasStorage"; | ||
| const aliasStore = useAliasStore(); | ||
| const { data: config, error } = await useFetch("/api/favorites/list"); | ||
| const boundaryTerm = aliasStore.BoundaryAlias; |
Collaborator
There was a problem hiding this comment.
Getting lint errors that this isn't used.
Collaborator
There was a problem hiding this comment.
Multiword error flagging. FavoriteTable, FavoritesView maybe?
| await navigateTo({ | ||
| path: "/company-boundary/" + favorite.id, | ||
| }); | ||
| } catch (error) { |
Collaborator
There was a problem hiding this comment.
Errors not showing in UI
| const user = await User.findByPk(body.id, { attributes: { exclude: ["password", "salt"] } }); | ||
|
|
||
| if (!user) { | ||
| if (!user ) { |
Collaborator
There was a problem hiding this comment.
remove added space from diff
|
|
||
| if (body.ThemeId && user.ThemeId !== body.ThemeId) { | ||
| user.ThemeId = body.ThemeId; | ||
| if (body.ThemeId && user.ThemeId !== body.ThemeId) { |
Collaborator
There was a problem hiding this comment.
remove added space from diff
| if (body.ThemeId && user.ThemeId !== body.ThemeId) { | ||
| user.ThemeId = body.ThemeId; | ||
| if (body.ThemeId && user.ThemeId !== body.ThemeId) { | ||
| user.ThemeId = body.ThemeId; |
Collaborator
There was a problem hiding this comment.
remove added space from diff
| @@ -1,4 +1,4 @@ | |||
| import { UserRole } from "../../../db/models"; | |||
| import { UserRole} from "../../../db/models"; | |||
Collaborator
There was a problem hiding this comment.
Replace the missing space to clean up diff
Collaborator
There was a problem hiding this comment.
There is no check to see if the user is a member and allowed to favorite. You can add a favorite to a boundary you don't belong to and then get the header information from a list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces support for user favorites by adding favorite relationships for Companies and Boundaries directly to Users. Adds APIs to manage favorites, displays favorites on the dashboard for quick access, and allows users to favorite and unfavorite items throughout the application.
Changes
Added
Changed
Testing
Related
Closes #213