Publish Docker image + one-click Claude Desktop extension (.mcpb) - #2
Merged
Merged
Conversation
… build approval Follow-up corrections to the merged mcpb extension: - Bundle mcp-remote and run it on Claude Desktop's own Node runtime instead of shelling out to npx. spawning npx.cmd needs shell:true on Windows (Node CVE-2024-27980), and shell:true would pass the token through a shell. The bundled launcher uses process.execPath + an args array, so install works identically on macOS, Windows and Linux with no system Node or network fetch. - build-mcpb.mjs installs the bundle's deps in an isolated temp dir (outside the repo) so pnpm doesn't pull in the project's workspace deps. - release.yml runs the build script via node directly, bypassing the pnpm script runner's project deps-status check. - pnpm-workspace.yaml: restore allowBuilds: esbuild: true. It is the only key that suppresses pnpm's unapproved-build error here; onlyBuiltDependencies (set in the merged PR) breaks every local 'pnpm <script>' invocation. - README: the extension no longer needs system Node or npx.
twiesing
force-pushed
the
feat/mcpb-extension-and-docker-fix
branch
from
June 29, 2026 12:59
0ac3628 to
3cc0235
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two things were blocking easy distribution:
Dockerworkflow failed on every push tomainbecausepnpm installexits non-zero on unapproved build scripts (esbuild, via vite/vitest) and the approval was never copied into the image. So neither:latestnor0.1.0exist on ghcr.io despite the README.X-ET-Tokenheader.What
9613506fix(docker) — install with--ignore-scriptsin both stages. The build stage only compiles viatsc; the runtime needs only zod + the MCP SDK, so no dependency build scripts are required. Verified: image builds,/health→{"ok":true,...}.0ac3628feat(mcpb) — a Claude Desktop extension (.mcpb): install by double-click, enter the access token in a form field, no config editing.mcp-remoteis bundled and runs on Claude Desktop's own Node runtime — nonpx, no system Node, no network fetch, no shell. Works identically on macOS, Windows and Linux; the token is passed as args, never through a shell.user_configfield.scripts/build-mcpb.mjs(+pnpm pack:mcpb) syncs the version, bundles deps in an isolated temp dir, and bakesETRACKER_MCP_URLinto the default when set.release.ymlbuilds and attaches the.mcpbto GitHub Releases onv*.*.*tags.mcp-remotepath stays as a fallback.Verification
pnpm typecheck+pnpm testgreendocker buildsucceeds; container serves/health.mcpbbuilds (1.4 MB,mcp-remote/dist/proxy.jspresent); launcher starts mcp-remote and injects theX-ET-TokenheaderFollow-ups (not in this PR)
ETRACKER_MCP_URL(used by the release build) or themanifest.jsondefault. Currently a placeholderhttps://etracker-mcp.mittwald.de/mcp.Dockerworkflow only runs onmain, so the image publishes on merge. Tagv0.1.0afterwards to produce the semver image and the first.mcpbrelease.