Conversation
…settings UI changes
Owner
|
I merged the store‑listing PR after making some edits. Specifically, I switched from destroying and rebuilding This requires a small change in the Raven PR: StoreListings.Library.ProxyManager.Proxy = webProxy;instead of StoreListings.Library.Internal.ProxyManager.SetProxy(webProxy); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Proxy support (new feature)
IProxyService,ProxyService,ProxyEntry- manage multiple proxy entries with runtime switchingDownloadLocationService- configurable download locationSettingsPage.xaml/.cs,SettingsViewModel)Resources.reswApp.xaml.cs,ActivationService,DownloadManagerService,GitHubUpdaterService,DownloadHelperStoreListings dependency
This feature needs the proxy-routing changes in the StoreListings submodule (
ProxyManager+Helpers.cs). Those are submitted separately as mjishnu/StoreListings#1..gitmodulesis untouched - once that PR is merged, this PR's submodule pointer can be bumped to the upstream commit and everything stays on mjishnu/StoreListings. Until then, this branch points the submodule at my fork commit (ddf5abf) so it remains buildable/testable.All changes built and tested locally (WinUI 3 / .NET 10, x64).