[Refactor] NPU FLA: delegate to fla native operators, remove MindSpeed/twinkle-own kernels#251
Merged
Merged
Conversation
- Remove twinkle-own Triton kernels (causal_conv1d.py, chunk_gated_delta_rule.py) that depended on MindSpeed; delegate to fla's native causal_conv1d and chunk_gated_delta_rule which ship their own Ascend-backend dispatch - Move npu_causal_conv1d_fn adapter into npu_impls/fla.py; drop redundant weight transpose (fla expects [D,W], not [W,D]) - Simplify builtin.py FLA dependency check: only requires flash-linear-attention (no longer mindspeed>=0.12.1) - Update gdn_padding_free.py import path for npu_causal_conv1d_fn - Clean up unused Optional import and fix activation type hint - Update tests to stub fla package as unavailable
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
kevssim
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Experiment results
Test environment
Unit tests
tests/kernel/+tests/patch/: 66 passed, 5 skippedtest_qwen35_fla_bwd_precision.py(bf16 fla vs fp32 torch): 3 passedfsdp2 e2e (Qwen3.5-4B, fsdp=8, dp=1, max_length=8192)
max |diff| = 0.0012, mean |diff| = 0.0007
sp2 e2e (Qwen3.5-4B, fsdp=8, dp=1, ulysses=2, max_length=8192)
max |diff| = 0.0017, mean |diff| = 0.0008