feat(mongodb-ns): show __mdb_internal_search in database lists COMPASS-10948 - #853
Open
karimelhammady wants to merge 1 commit into
Open
feat(mongodb-ns): show __mdb_internal_search in database lists COMPASS-10948#853karimelhammady wants to merge 1 commit into
karimelhammady wants to merge 1 commit into
Conversation
…S-10948 Exempt the __mdb_internal_search database (Atlas Auto-Embedding storage) from `internal` so UIs like Compass's database list stop hiding it, while keeping it `special`/`specialish` via a dedicated clause so it retains system-namespace treatment everywhere else.
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts mongodb-ns namespace classification so __mdb_internal_search is no longer treated as internal (and thus not hidden by UIs filtering on that flag) while still being treated as MongoDB machinery via special/specialish.
Changes:
- Exempt
__mdb_internal_searchfrominternaldetection while keeping other__mdb_internal_*databases internal. - Add an explicit
specialclause for__mdb_internal_searchto preserve “machinery” behavior without relying oninternal. - Add/extend tests and document the updated
internalsemantics.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/mongodb-ns/src/index.ts | Updates internal regex and keeps __mdb_internal_search classified as special. |
| packages/mongodb-ns/src/index.spec.ts | Adds coverage for the __mdb_internal_search exemption and special/specialish behavior. |
| packages/mongodb-ns/README.md | Documents the internal exception for __mdb_internal_search and shows internal in the example output. |
Suppressed comments (1)
packages/mongodb-ns/src/index.spec.ts:80
- Test case description has a spelling typo: "acccept" should be "accept".
it('should acccept `__mdb_internal_search`', function () {
assert(ns('__mdb_internal_search').specialish);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+72
to
+74
| // COMPASS-10948: special via its own clause, not via `internal`. | ||
| it('should acccept `__mdb_internal_search`', function () { | ||
| assert(ns('__mdb_internal_search').special); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Auto-Embedding stores its generated embeddings in
__mdb_internal_searchon the customer's cluster, and customers need to browse them. UIs hide__mdb_internal_*databases by filtering oninternal, so Compass and Data Explorer currently drop it from the database list.internalboth classifies internal databases and drives that filtering. This separates the two:__mdb_internal_searchis exempt frominternalso it is no longer hidden, while a dedicated clause keeps itspecial/specialish— it is still a MongoDB-managed database. Both changes need to stay together: without thespecialclause, Compass treats these collections as user data and offers the Global Writes tab and the data-modeling wizards for them. The match is exact, so__mdb_internal_search_*and every other__mdb_internal_*database stayinternal.Open Questions
On multi-tenant clusters mongot can name this database
<prefix>___mdb_internal_search, taking the prefix from the source database name and falling back to the bare name when it has no underscore AtlasInternalDatabaseResolver. The prefixed form never matched^__mdb_internal_, so it is already visible but neverspecial, and the exact match here doesn't cover it — should the clause use a suffix match instead? This is from reading the resolver; I haven't confirmed it against a live multi-tenant cluster.Checklist