♻️ Own neutral-atom stack

[denialhaag]

🤖 AI text below 🤖

Description

This PR transfers the neutral-atom computation IR, circuit operations, mapping integration, QDMI provider and client, Python bindings, device data, documentation, and tests from Core to QMAP. NALAC remains self-contained.

Move and bridge operations derive from Core's custom-operation base so the serializer can dispatch them correctly. Device discovery opens every registered device ID once and preserves devices that share a display name. The QMAP provider uses mqt.qmap.na.default and ships its configuration beside the library.

This branch supports Core 3.9. The companion Core 3.10 integration is in #1144, together with #1124 and #1125.

Validation

• Native neutral-atom tests: 178 passed, 1 skipped; hybrid mapper: 101 passed.
• Python neutral-atom tests: 24 passed, 1 skipped.
• Full uvx nox -s lint and targeted clang-tidy 20 checks passed locally.
• Hosted checks must validate the new head.

AI assistance

Opus 5 via Claude Code, GPT-5.6 Sol via Codex, and GPT-6 via Codex assisted with this contribution. A human must review the updated changes.

Checklist

• The pull request only contains commits that are focused and relevant to this change.
• I have added appropriate tests that cover the new/changed functionality.
• I have updated the documentation to reflect these changes.
• I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
• I have added migration instructions to the upgrade guide (if needed).
• The changes follow the project's style guidelines and introduce no new warnings.
• The changes are fully tested and pass the CI checks.
• I have reviewed my own code changes.

If PR contains AI-assisted content:

• Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
• Every agent-authored or agent-edited public text body begins with the visible disclosure 🤖 *AI text below* 🤖 (titles are exempt).
• I have disclosed AI assistance in the PR description.
• I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

[codecov]

Codecov Report

❌ Patch coverage is 86.95652% with 312 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/na/fomac/Device.cpp	71.9%	108 Missing ⚠️
src/na/qdmi/Configuration.cpp	89.7%	36 Missing ⚠️
src/na/qdmi/Device.cpp	91.4%	36 Missing ⚠️
src/hybridmap/MoveToAodConverter.cpp	88.7%	35 Missing ⚠️
include/na/qdmi/Configuration.hpp	72.3%	21 Missing ⚠️
src/na/ir/operations/AodOperation.cpp	85.6%	18 Missing ⚠️
include/na/ir/operations/AodOperation.hpp	54.5%	10 Missing ⚠️
src/na/ir/operations/NAStandardOperation.cpp	84.3%	8 Missing ⚠️
.../na/ir/operations/NAComputationGlobalOperation.cpp	63.1%	7 Missing ⚠️
src/na/ir/operations/NAOpType.cpp	88.8%	7 Missing ⚠️
... and 10 more

📢 Thoughts on this report? Let us know!

[burgholzer]

The neutral-atom QDMI device itself is deliberately left behind for now. Its implementation includes qdmi/common/DeviceConfiguration.hpp, which exists only on Core's main and not in the pinned v3.8.0, so the device cannot compile here until QMAP pins a Core release that ships it. The device tests and the FoMaC test are held back with it, since both need a registered neutral-atom QDMI device at runtime.

The Python bindings for mqt.core.na are not moved yet either. They bind na::Session::Device as deriving from fomac::Device, which Core registers in mqt.core.qdmi, so moving them requires wiring that base class across package boundaries.

Quite a bit of the code mentioned here has been backported to v3.x, so it can also be moved as part of this PR.

[denialhaag]

The neutral-atom QDMI device itself is deliberately left behind for now. Its implementation includes qdmi/common/DeviceConfiguration.hpp, which exists only on Core's main and not in the pinned v3.8.0, so the device cannot compile here until QMAP pins a Core release that ships it. The device tests and the FoMaC test are held back with it, since both need a registered neutral-atom QDMI device at runtime.
The Python bindings for mqt.core.na are not moved yet either. They bind na::Session::Device as deriving from fomac::Device, which Core registers in mqt.core.qdmi, so moving them requires wiring that base class across package boundaries.

Quite a bit of the code mentioned here has been backported to v3.x, so it can also be moved as part of this PR.

Yes, I just didn't do that just yet because I didn't want the Python CI to be red. The upcoming PR in MQT Core will be fully independent of all of this. Once 3.9.0 is released and MQT QCEC is updated accordingly, I'll get this PR ready. 😌

[denialhaag]

@burgholzer and @ystade, I have a quick question about whether (or how) the neutral-atom operations in na:: (that is, MQT Core's) and na::nalac:: should be consolidated. The operations belonging to the former use Location (aliasing double) and Atom, while the latter use Point (aliasing int64_t) and shared_ptr<Point>. Should I try consolidating them, or should they continue to coexist? 🤔

[ystade]

As soon as NALAC causes any issues, feel free to remove it. I just kept it as a legacy but it is Kinds deprecated. Consolidating anything here with respect to NALAC is a warte of time.

[burgholzer]

As soon as NALAC causes any issues, feel free to remove it. I just kept it as a legacy but it is Kinds deprecated. Consolidating anything here with respect to NALAC is a warte of time.

I think we do not need to remove it, necessarily. But what I take from your comment is that it is entirely fine to keep everything for NALAC self contained in its own directory and rather focus on a clean integration for the rest.

[denialhaag]

Some feedback:

[coderabbitai]

Important

Approval pending

CodeRabbit has no unresolved comments, but it has not reviewed the latest commit.

Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[denialhaag]

@burgholzer, I iterated on this quite a bit more today and hopefully brought it to a decent state now. I gave Codex quite a few guardrails to streamline things and context to align the implementation with existing ones (in particular, QMDI-on-IQM). I'm sure there's some more room for improvement, but I think your additional human context may be required for that.

CC @ystade

[burgholzer]

I think I have iterated enough on this. Let's get it in to move the release along 😌