Skip to content

Build grimblast from source for Arch-based systems - #1790

Open
hurlbutt wants to merge 2 commits into
mylinuxforwork:mainfrom
hurlbutt:build-grimblast-from-source-for-arch
Open

Build grimblast from source for Arch-based systems#1790
hurlbutt wants to merge 2 commits into
mylinuxforwork:mainfrom
hurlbutt:build-grimblast-from-source-for-arch

Conversation

@hurlbutt

Copy link
Copy Markdown
Contributor

Description

#1783 discusses removing AUR-dependencies if possible. Right now, Arch-users using this project's dotfiles will install grimblast (used for screenshots) from the AUR while other distros build directly from source. Given we already have the logic in place to install grimblast fresh for all other distros, we can extend this to grimblast as well.

Changes

  • Removed grimblast-git as an Arch-distro dependency
  • [X} Updated post-arch.sh to query pacman for grimblast-git, and if not found download and build grimblast from source.

How Has This Been Tested?

Hasn't been tested end-to-end, but will post in #1783 to see if reporter can assist with testing.

  • Tested on Arch Linux/Based Distro.
  • Tested on Fedora Linux/Based Distro.
  • Tested on openSuse.

Checklist

Please ensure your pull request meets the following requirements:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes do not introduce new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes.

Related Issues

#1783

@hurlbutt

Copy link
Copy Markdown
Contributor Author

#1792 provides most of these changes, so I modified the PR to just check for grimblast-git being installed/managed before attempting to install from source.

@mylinuxforwork

Copy link
Copy Markdown
Owner

Hi. It is already implemented in the current Rolling Release.
Can you check?

@hurlbutt

Copy link
Copy Markdown
Contributor Author

@mylinuxforwork - Correct, in #1792 you updated setup/post-arch.sh to call setup/clean-install-grimblast.sh to install grimblast from source for Arch-based installations. However, previous to this change anyone using these dotfiles will have grimblast installed via the grimblast-git AUR package due to the previous install scripts. For users who already have that package installed (either via the previous install script or through direct installation), we should not be manually uninstall/reinstalling grimblast and should allow yay/paru to manage that installation going forward.

After your changes, all this PR does now is call pacman -Qi grimblast-git &>/dev/null to see if grimblast is being managed by an AUR helper, and, if not, then calls setup/clean-install-grimblast.sh to handle the direct installation. Looking through the code, I do not see where the installer guards against AUR-managed grimblast package installs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants