You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#1783 discusses removing AUR-dependencies if possible. Right now, Arch-users using this project's dotfiles will install grimblast (used for screenshots) from the AUR while other distros build directly from source. Given we already have the logic in place to install grimblast fresh for all other distros, we can extend this to grimblast as well.
Changes
Removed grimblast-git as an Arch-distro dependency
[X} Updated post-arch.sh to query pacman for grimblast-git, and if not found download and build grimblast from source.
How Has This Been Tested?
Hasn't been tested end-to-end, but will post in #1783 to see if reporter can assist with testing.
Tested on Arch Linux/Based Distro.
Tested on Fedora Linux/Based Distro.
Tested on openSuse.
Checklist
Please ensure your pull request meets the following requirements:
My code follows the style guidelines of this project.
I have performed a self-review of my code.
I have commented on my code, particularly in hard-to-understand areas.
My changes do not introduce new warnings.
I have added tests that prove my fix is effective or that my feature works.
I have made corresponding changes to the documentation
New and existing unit tests pass locally with my changes.
#1792 provides most of these changes, so I modified the PR to just check for grimblast-git being installed/managed before attempting to install from source.
@mylinuxforwork - Correct, in #1792 you updated setup/post-arch.sh to call setup/clean-install-grimblast.sh to install grimblast from source for Arch-based installations. However, previous to this change anyone using these dotfiles will have grimblast installed via the grimblast-git AUR package due to the previous install scripts. For users who already have that package installed (either via the previous install script or through direct installation), we should not be manually uninstall/reinstalling grimblast and should allow yay/paru to manage that installation going forward.
After your changes, all this PR does now is call pacman -Qi grimblast-git &>/dev/null to see if grimblast is being managed by an AUR helper, and, if not, then calls setup/clean-install-grimblast.sh to handle the direct installation. Looking through the code, I do not see where the installer guards against AUR-managed grimblast package installs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#1783 discusses removing AUR-dependencies if possible. Right now, Arch-users using this project's dotfiles will install
grimblast(used for screenshots) from the AUR while other distros build directly from source. Given we already have the logic in place to installgrimblastfresh for all other distros, we can extend this togrimblastas well.Changes
grimblast-gitas an Arch-distro dependencypost-arch.shto querypacmanforgrimblast-git, and if not found download and buildgrimblastfrom source.How Has This Been Tested?
Hasn't been tested end-to-end, but will post in #1783 to see if reporter can assist with testing.
Checklist
Please ensure your pull request meets the following requirements:
Related Issues
#1783