Persist final downlink metadata - #253
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
FarkasJoseph
left a comment
There was a problem hiding this comment.
lgtm; should likely be e2e tested
Contributor
Author
|
Thanks. I checked the integration harness before expanding this. The regression in this PR already drives the real |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #237.
Keep the existing early metadata write for crash resilience, then rewrite the
.md.pbsidecar after downlink validation has established the final completion status. The final write includestime_end, so the persisted metadata now matches theFileDownlinkemitted on the bus.The metadata writer seeks to the start and truncates before rewriting, avoiding stale protobuf bytes when the final message is shorter than the early snapshot.
Validation:
go test ./pkg/dwngo test ./pkg/...git diff --checkThe regression test decodes the written sidecar and verifies that its final status and end time match the completed downlink message.